Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added note for Windows users to install Docker 2.1.0.5 or below. #160

Merged
merged 3 commits into from Jun 9, 2020

Conversation

rawadelkontar
Copy link
Contributor

@rawadelkontar rawadelkontar commented May 29, 2020

Fixes #157

Pull Request Description

Added note for Windows users to install Docker 2.1.0.5 or below.

Checklist

Not all may apply

  • Code changes (must work)
  • Tests exercising your feature/bug fix (check coverage report on CircleCI build -> Artifacts)
  • All other unit tests passing
  • Update validation for project config yaml file changes
  • Update existing documentation
  • Run a small batch run to make sure it all works (local is fine, unless an Eagle specific feature)
  • Add to the changelog_dev.rst file and propose migration text in the pull request

nmerket
nmerket previously approved these changes May 29, 2020
Copy link
Member

@nmerket nmerket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for figuring this out!

@nmerket
Copy link
Member

nmerket commented May 29, 2020

It looks like we have some unrelated bug in testing happening. I'll try to fix that separately today before merging this in.

There was a bug introduced in pandas 1.0.4 that caused pd.read_parquet to no longer be able to handle file-like objects. They're fixing it in 1.0.5. This change will skip 1.0.4 and use the newer version when available.
pandas-dev/pandas#34467
@nmerket
Copy link
Member

nmerket commented Jun 9, 2020

There was a bug introduced in pandas 1.0.4 that caused pd.read_parquet to no longer be able to handle file-like objects. They're fixing it in 1.0.5. This change will skip 1.0.4 and use the newer version when available.
pandas-dev/pandas#34467

This should get the tests to pass again.

@nmerket nmerket merged commit 93f8f4a into master Jun 9, 2020
@nmerket nmerket deleted the docs_minor_update branch June 9, 2020 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'os_measures' error et al. when running Docker on Windows with latest version of OS-BS
2 participants