New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Descriptive error for post processing empty results #152
Conversation
@nmerket I have added a error message when no results are found in Also, I am not sure if we need a more descriptive message, I figured this issue could arise a few different ways (eg, timeout or all sims failed), so it is currently pretty vague. |
@aspeake This is a good start. I might just raise an exception with the error message. It's probably fine the way it is as far as descriptiveness. Just knowing that much will give people a clue where to start looking next. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. One suggestion below. I think it's ready. If you do too, mark it ready for review so I can merge it.
Co-authored-by: Noel Merket <noel.merket@nrel.gov>
@nmerket this should be ready for review + merge |
Fixes #151
Pull Request Description
Throws a more descriptive error in post-processing when no simulation results are found
Checklist
Not all may apply