feat: use proc-log and drop support for log property #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukekarrys
commented
Feb 10, 2022
|
When you rebase make it a |
lukekarrys
force-pushed
the
lk/proc-log
branch
from
e49c14c
to
7cba1e0
Compare
lukekarrys
force-pushed
the
lk/proc-log
branch
from
7cba1e0
to
9426336
Compare
It replaces the only use of `npmlog.level` with a boolean `silent` which is now used to to suppress `@npmcli/run-script` banners instead. BREAKING CHANGE: this drops support for the `log` property and instead all logs will be emitted on the process object via `proc-log`.
lukekarrys
force-pushed
the
lk/proc-log
branch
from
9426336
to
ecf9232
Compare
lukekarrys
changed the title
|
This closes #105 now. |
wraithgar
approved these changes
Feb 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It replaces the only use of
npmlog.levelwith a booleansilentwhichis now used to to suppress
@npmcli/run-scriptbanners instead.BREAKING CHANGE: this drops support for the
logproperty and insteadall logs will be emitted on the process object via
proc-log.