Skip to content
This repository has been archived by the owner on Aug 11, 2021. It is now read-only.

Please remove dependency on os-homedir #11

Open
pravi opened this issue Oct 18, 2016 · 5 comments · May be fixed by #19
Open

Please remove dependency on os-homedir #11

pravi opened this issue Oct 18, 2016 · 5 comments · May be fixed by #19

Comments

@pravi
Copy link

pravi commented Oct 18, 2016

Its has serious unfixed issues https://github.com/sindresorhus/os-homedir/issues/4 expand-tilde already removed this dependency.

jonschlinkert/expand-tilde@e13f94a

@iarna
Copy link
Contributor

iarna commented Oct 18, 2016

As of this writing osenv is a dependency of npm and npm supports node 0.10. Node 0.10 does not support os.homedir as such, some shim is required and without that we can't just ditch os-homedir. If you have a better shim for it then I suspect you won't have trouble getting a PR for os-homedir accepted to use it.

@pravi
Copy link
Author

pravi commented Oct 19, 2016

@iarna, fair enough you want to support older nodejs versions, but are you saying its the responaibility of random bug reporters to fix critical bugs in your own code? Or are you saying the bug in os-homedir somehow does not affect your code?

@pravi
Copy link
Author

pravi commented Oct 19, 2016

As for my usecase, debian has on older osenv without os-homedir dependency and since we already have a newer nodejs, we don't need os-homedir. So I don't need to fix os-homedir. It is upto you, how you want to keep your code in good shape.

@we11adam
Copy link

IMHO, this case should be taken of specially. We can't rely on an underlying implementation known to be defected. Can we implement our own polyfill on the npm side?

@iarna
Copy link
Contributor

iarna commented Apr 21, 2017

I don't see this as critical as you seem to (obviously seeing as I'm just getting back to this now). We have a very, very small team and so our work is all about triage. I wasn't insisting that you do any work, just telling you what we could and could not accept.

@welladamm We could patch os-homedir itself if anyone could come up with better behavior. Thus far I've seen no proposals. (The suggestions in the linked issue are all about C-system calls that are unavailable in Node. Any solution must be pure-JS.)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants