Skip to content
This repository has been archived by the owner on Aug 11, 2022. It is now read-only.

"npm install" should not warn about failed optional dependencies which are not relevant for my os/architecture #17466

Open
1 of 4 tasks
oocx opened this issue Jun 27, 2017 · 2 comments

Comments

@oocx
Copy link

oocx commented Jun 27, 2017

I'm opening this issue because:

  • npm is crashing.
  • npm is producing an incorrect install.
  • npm is doing something I don't understand.
  • Other (see below for feature requests):

What's going wrong?

I'm filing a new issue as #11632 was closed automatically due to inactivity. The problem still exists. "npm install" outputs warnings for packages that I don't need on my platform. npm install should never output warnings if everything installed as expected.

Usually, we have a policy that warnings in our builds should be fixed. Bugs like this make this policy complex, as it introduces exceptions to the "no warnings" rule that our developers need to know and understand.

How can the CLI team reproduce the problem?

Install a package that requires /chokidar/fsevents on Windows.

supporting information:

For more information and discussion, see issue #11632

@ashwell
Copy link

ashwell commented Jul 26, 2017

Just saw this warning on our project running npm install on Amazon Linux.

To make things even worse, npm decided to remove fsevents from shrinkwrap.json as well.

Edit: to clarify, I see there are a ton of other issues talking about problems with optional deps and lock files.

@YasharF
Copy link

YasharF commented Dec 29, 2017

New PR: #19198

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants