fix: do not overwrite bundled dependency ranges with * #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI failures are due to an old config, every node version that fails is no longer supported. |
nlf
force-pushed
the
nlf/dont-wildcard-bundled-deps
branch
from
c652796
to
63c67c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this corrects a regression where we started overwriting dependencies that are present in both
dependenciesandbundleDependencieswith a*when the original intent was to add dependencies that were present inbundleDependenciesbut not independencieswith a range of*this fixes the issue where our own published package.json has
*for the range for every dependency