Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] --no-[parameterName] doesn't allow setting to null for some typeDefs #79

Open
speige opened this issue Feb 3, 2017 · 0 comments
Labels
Bug thing that needs fixing

Comments

@speige
Copy link

speige commented Feb 3, 2017

The purpose of "--no-myParam" is to allow setting a parameter to null instead of undefined, because "-myParam null" would set it to the string value 'null' instead of the javascript value null.

However, this feature is buggy for some typeDefs.

if typeDef is String
"--no-myParam" the parse() function sets it to false instead of null
However, clean() internally calls validateString() which changes it to 'false'

so, "--no-myParam" has no purpose in the case of typeDef String because i could have used "-myParam false" instead.

I haven't tested to see if the other typeDefs have similar issues, but it's possible.

@darcyclarke darcyclarke changed the title --no-[parameterName] doesn't allow setting to null for some typeDefs [BUG] --no-[parameterName] doesn't allow setting to null for some typeDefs Jul 28, 2022
@darcyclarke darcyclarke added the Bug thing that needs fixing label Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug thing that needs fixing
Projects
None yet
Development

No branches or pull requests

2 participants