This repository has been archived by the owner on May 4, 2024. It is now read-only.
fix: use more commonly available character for pre/post progressbar #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wraithgar
approved these changes
Feb 15, 2022
|
the above test failures are due to a known issue in updating npm in windows, i'll follow up with a pull request that gets our CI config updated |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current characters are left and right double parenthesis, however it seems that these characters are not available in very many fonts. This means users leveraging a terminal that doesn't support fallback fonts for missing glyphs will get the unicode missing character glyph instead.
To make this a little cleaner, I swapped them out for standard single left and right parenthesis which should be available in the vast majority of fonts.