Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] npm run is broken #1704

Closed
ahuglajbclajep opened this issue Aug 23, 2020 · 3 comments
Closed

[BUG] npm run is broken #1704

ahuglajbclajep opened this issue Aug 23, 2020 · 3 comments
Labels
Bug thing that needs fixing Needs Triage needs review for next steps Release 7.x work is associated with a specific npm 7 release

Comments

@ahuglajbclajep
Copy link

Current Behavior:

$ npx -qp npm@7.0.0-beta.5 -c 'npm run'
start:webpack-dev-server --open
build:NODE_ENV=production webpack -p

$ npx -qp npm@7.0.0-beta.6 -c 'npm run'
npm timing config:load:defaults Completed in 1ms
...
npm timing npm:load Completed in 25ms
npm run-script <command> [-- <args>]

aliases: run, rum, urn
npm timing npm Completed in 155ms

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/ahu/.npm/_logs/2020-08-23T00_18_04_815Z-debug.log

Expected Behavior:

$ npx -qp npm@7.0.0-beta.6 -c 'npm run'
start:webpack-dev-server --open
build:NODE_ENV=production webpack -p

Steps To Reproduce:

  1. npx -qp npm@7.0.0-beta.6 -c 'npm run'

Environment:

  • OS: macOS Catalina 10.15.6
  • Node: 12.18.3
  • npm: 6.14.6
  • npx: 6.14.6
@ahuglajbclajep ahuglajbclajep added Bug thing that needs fixing Needs Triage needs review for next steps Release 7.x work is associated with a specific npm 7 release labels Aug 23, 2020
@isaacs
Copy link
Contributor

isaacs commented Aug 25, 2020

Root cause: npm/config#2

We should be skipping env values of '' rather than putting them in the configuration object.

@ljharb
Copy link
Collaborator

ljharb commented Aug 25, 2020

Isn’t the empty string distinct from unset?

@isaacs
Copy link
Contributor

isaacs commented Sep 18, 2020

It is, but unfortunately npm 6 did not respect this distinction appropriately.

Fixed in latest beta.

@isaacs isaacs closed this as completed Sep 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug thing that needs fixing Needs Triage needs review for next steps Release 7.x work is associated with a specific npm 7 release
Projects
None yet
Development

No branches or pull requests

3 participants