Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Integrations require enumeration of providers inside the library #56

Open
toddb opened this issue Aug 27, 2023 · 1 comment
Open

Comments

@toddb
Copy link
Collaborator

toddb commented Aug 27, 2023

Providers are currently stringly known and undocumented.

The full list is here and should be introduced into the library.

However, C# doesn't implement enums with inheritance that you get with typescript. Either

  • implement a global provider list and attribute provider types (aka tag)
  • implement an enum-type factor provider

Note: validators could be put on the models and/or auto population of provider type based on name.

@wh1337
Copy link
Collaborator

wh1337 commented Aug 28, 2023

With this, we would have to keep this in sync with Novu to ensure downstream clients aren't effected. Not impossible or alot to do, but just wanted to make the statement

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants