Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing methods #33

Open
sumitsaurabh927 opened this issue Sep 18, 2023 · 12 comments
Open

Missing methods #33

sumitsaurabh927 opened this issue Sep 18, 2023 · 12 comments
Assignees
Labels
enhancement New feature or request hacktoberfest

Comments

@sumitsaurabh927
Copy link
Contributor

Some endpoints of the following section can't be hit from this SDK. Please ensure that all the SDK methods are up to date. I'm adding here a list of sections to check/update:

  • Notification templates
  • Integrations
  • Layouts
  • Inbound Parse
  • Environments
  • Changes
  • Execution details
  • Feeds
  • Messages
  • Blueprints

Some of these methods already exist. No need to change/update them. This is just to bring every SDK we have on par with all the methods available.

Check all the endpoints here and add the missing ones.

@sumitsaurabh927 sumitsaurabh927 added the enhancement New feature or request label Sep 18, 2023
@Cliftonz
Copy link
Contributor

@sumitsaurabh927 Can you do the same for this one? Thank you!

@sumitsaurabh927
Copy link
Contributor Author

Sure, I'll update this issue on every relevant SDK

@king-11
Copy link
Contributor

king-11 commented Oct 2, 2023

Hi @Cliftonz @sumitsaurabh927 can I take this up?

@sumitsaurabh927
Copy link
Contributor Author

Hi @Cliftonz @sumitsaurabh927 can I take this up?

Sure @king-11 assigning this to you

@sumitsaurabh927
Copy link
Contributor Author

And @king-11 let me know if you're facing any problems!

@king-11
Copy link
Contributor

king-11 commented Oct 2, 2023

Thanks will do 😄

@king-11
Copy link
Contributor

king-11 commented Oct 2, 2023

I took a look at integrations in Swagger a lot of the end points are missing so I need to add them as new functions in the interface and do the same procedure for other listed endpoints.

@king-11
Copy link
Contributor

king-11 commented Oct 2, 2023

Tracking endpoints that are either complete or PR has been made for them

  • event
  • subscribers
    • Get Subscribers
    • Bulk Create Subscribers
    • Update Subscriber Credentials
    • Delete Subscriber Credentials
    • Update Subscriber online status
    • Mark all Subscriber Messages
    • Mark Message action as seen
    • Handle OAuth Redirect
    • Handle Chat oauth
  • topics
    • Check Topic Subscriber
  • integrations
    • webhook update status

@king-11
Copy link
Contributor

king-11 commented Oct 2, 2023

@sumitsaurabh927 I have raised a PR requesting your review. Please let me know if you would want all the missing methods in one PR or I can go endpoint by endpoint.

@sumitsaurabh927
Copy link
Contributor Author

One PR would be fine!

@king-11
Copy link
Contributor

king-11 commented Oct 2, 2023

sure would need sometime for the same

@king-11
Copy link
Contributor

king-11 commented Oct 2, 2023

I am thinking to constrain the PR to just topic and integration because there are just too many new additions for subscriber endpoint will be sending another PR for all the missing options there, we can probably keep the issue open?

Edit: updated previous comment with all the missing methods for subscriber

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hacktoberfest
Projects
None yet
Development

No branches or pull requests

3 participants