Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow graceful reloads in case of certificate changes #374

Open
jackie-t opened this issue Jan 14, 2019 · 3 comments
Open

Allow graceful reloads in case of certificate changes #374

jackie-t opened this issue Jan 14, 2019 · 3 comments
Labels
feature New feature or request

Comments

@jackie-t
Copy link

I currently can't find a way to gracefully reload websockify in case the certificate changes.

With graceful I'd mean something similar to haproxy - when you reload haproxy, all existing connections are still served, but new ones receive the new certificate. At the moment, I restart websockify, which terminates any connections.

This would - I imagine - become more needed with let's encrypt, especially if they intend to shorten the certificate validity further.

If this is already possible, documentation would help in avoiding similar questions. ;)

@CendioOssman
Copy link
Member

Unfortunately I don't think it is likely we'll support this as it is not supported by multiprocessing, which is the core architecture of the current code. :/

@CendioOssman CendioOssman added feature New feature or request python labels Jan 18, 2019
@samhed samhed removed the python label Sep 26, 2019
@valerio-bozzolan
Copy link

valerio-bozzolan commented Apr 8, 2020

Unfortunately I don't think it is likely we'll support this as it is not supported by multiprocessing, which is the core architecture of the current code. :/

Hello!

Apologies if I actually don't know well the codebase to understand if multiprocessing is something not related to this project. Does it exist an upstream bug about what you say?

Thank you.

@CendioOssman
Copy link
Member

It's about the current architecture of websockify, so I don't think upstream Python needs to modify anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants