Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong physical key code for "<" and "§" on ISO keyboards in Safari #1680

Open
CendioOssman opened this issue Aug 22, 2022 · 0 comments
Open
Labels

Comments

@CendioOssman
Copy link
Member

Describe the bug
The mentioned keys send the correct KeySym, but the wrong physical key code when using Safari (on macOS). This is problematic if the server is configured to use physical keys rather than symbolic ones.

To Reproduce

  1. Connect a keyboard with ISO layout (e.g. Swedish)
  2. Press the key to the left of "1".

Expected behavior
The server reacts as if the key left of "1" was pressed. Right now, it reacts as if the key between shift and "z" was pressed.

Client (please complete the following information):

  • OS: macOS 12
  • Browser: Safari
  • Browser version: 15.6.1

Server (please complete the following information):

  • noVNC version: 8329372
  • VNC server: TigerVNC
  • WebSocket proxy: websockify

Additional context
This is a long-standing misfeature in macOS, that apparently Chrome and Firefox compensate for. But not Safari. I've reported the issue here:

https://bugs.webkit.org/show_bug.cgi?id=244202

Unfortunately, the bug is per keyboard. So, I'm not sure if we have access to enough information to fix it from JavaScript. I don't see any difference between the events that need to be adjusted, and the events that are correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant