Skip to content
This repository has been archived by the owner on Apr 30, 2021. It is now read-only.

Add the ability to change the dimension #21

Open
nagadit opened this issue Feb 26, 2020 · 3 comments
Open

Add the ability to change the dimension #21

nagadit opened this issue Feb 26, 2020 · 3 comments
Labels
enhancement New feature or request

Comments

@nagadit
Copy link

nagadit commented Feb 26, 2020

I have glove 300d vectors only.
Change pls code here and here to this:
def train(x, y, vx, vy, epochs, batch_size, save_folder, glove_path, dim_glove=100)
and
model = seqtag_keras.Sequence(embeddings=embeddings, word_embedding_dim=dim_glove, word_lstm_size = dim_glove)
tnx

@nagadit nagadit changed the title Add a change in the dimension of vectors Add the ability to change the dimension Feb 26, 2020
@bedapudi6788
Copy link
Collaborator

@good-mouse 300d vectors are mostly a overkill and will result in at least 4x performance degradation.

If you really need support for 300d vectors inside the library, please consider making a PR. I will be more than happy to help if you need any guidance for that.

@bedapudi6788 bedapudi6788 added the enhancement New feature or request label Feb 26, 2020
@bedapudi6788
Copy link
Collaborator

  1. Fork the repo.
  2. create a new branch
  3. Make your changes and push to your forked repo.
  4. Create a pull request.

https://yangsu.github.io/pull-request-tutorial/

@nagadit
Copy link
Author

nagadit commented Feb 26, 2020

@bedapudi6788 I thought you mean PR as an advertisement 😄

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants