Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"sunken-button" no longer valid style in emacs master #130

Open
cybercode opened this issue Dec 9, 2023 · 0 comments
Open

"sunken-button" no longer valid style in emacs master #130

cybercode opened this issue Dec 9, 2023 · 0 comments

Comments

@cybercode
Copy link

cybercode commented Dec 9, 2023 •
edited

In the latest master branch of emacs (v30), :style sunken-button generates a load error (invalid face). The definition :style pressed-button seems to be the visual equivalent.
cariandrum22 added a commit to cariandrum22/emacs that referenced this issue Feb 18, 2024
@cariandrum22
Fix Invalid face box error (nordtheme#130)
e6977cf 
The `style` attribute `sunken-button` for the `:box` attribute set on a
`button` or `custom-button*` is not a valid value[1].

This was not made manifest by a bug[2] on the emacs side but is expected
to be fixed and become an error in the version 30 release.

In the context of the code, `sunken-button` itself is considered
equivalent to `pressed-button`, so all places where `sunken-button` is
specified have been replaced with `pressed-button`.

[1]: https://www.gnu.org/software/emacs/manual/html_node/elisp/Face-Attributes.html
[2]: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=67404
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cybercode