Skip to content

merge from branch 34 - 1 #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 7, 2025
Merged

Conversation

noobdevsam
Copy link
Owner

No description provided.

@noobdevsam noobdevsam self-assigned this Jul 7, 2025
@noobdevsam noobdevsam added the enhancement New feature or request label Jul 7, 2025
@noobdevsam noobdevsam requested a review from Copilot July 7, 2025 13:45
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR centralizes configuration by removing local settings from the customer-service and moving them into the config-server’s native store.

  • Removed embedded MongoDB, port, and Eureka settings from customer-service and added a config import
  • Added service-specific and global YAML under config-server’s serviceconfigs directory
  • Enabled the native profile and pointed the config server to classpath:/serviceconfigs

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
micro-services/customer-service/src/main/resources/application.yml Removed local config entries and added spring.config.import entry
micro-services/config-server-service/src/main/resources/serviceconfigs/customer-service.yml Added dedicated config for customer-service
micro-services/config-server-service/src/main/resources/serviceconfigs/application.yml Introduced global serviceconfigs application YAML
micro-services/config-server-service/src/main/resources/application.yml Activated native profile and configured search-locations
Comments suppressed due to low confidence (2)

micro-services/customer-service/src/main/resources/application.yml:5

  • The import property is currently nested under spring.application. It should be placed under spring.config.import so the config server URL is recognized correctly.
        import: optional:configserver:http://localhost:8086

micro-services/config-server-service/src/main/resources/serviceconfigs/application.yml:1

  • Defining name.value won’t set the Spring application name. Replace with spring.application.name: sampleconfigserver to ensure the config server identifies itself properly.
name:

Copy link
Owner Author

@noobdevsam noobdevsam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all ok

@noobdevsam noobdevsam merged commit 0e7adb9 into master Jul 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant