Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NSFS | NamespaceFS.js Error handling #8041

Open
romayalon opened this issue May 12, 2024 · 0 comments
Open

NSFS | NamespaceFS.js Error handling #8041

romayalon opened this issue May 12, 2024 · 0 comments
Labels
Milestone

Comments

@romayalon
Copy link
Contributor

Environment info

  • NooBaa Version: 5.17
  • Platform: All

Actual behavior

  1. Currently, on many NamespaceFS functions we handle/throw all errors the same way, even if they originated from different internal functions and should be treated as internal failures.
  2. Most functions have a wrapping try catch and every FS error is translated to S3 error. On some cases this is something we want to avoid.
    For instance - In various cases of calling stat() of internal paths checks, we will throw a non-internal error, like ENOENT - NoSuchObject, which is incorrect. we need to have a correct error handling for each
    In PR we started handling this issue on HEAD object.

Expected behavior

  1. Internal issues throwing internal errors.

Steps to reproduce

More information - Screenshots / Logs / Other output

@nimrod-becker nimrod-becker added this to the 5.16.z milestone May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants