NC | Noobaa syslogs are sent to two different files

[naveenpaul1]

Environment info

• NooBaa Version: VERSION
• Platform: Kubernetes 1.14.1 | minikube 1.1.1 | OpenShift 4.1 | other: specify

Actual behavior

debug_module sends every log message to two targets but but native code logs only to stderr at the moment.

1. syslog facility local0 - rsyslog omfile copies it to /var/log/noobaa.log
2. stdout/stderr - systemd copies it into its journal and then rsyslog imjournal copies it to the file /var/log/messages.
3. send strerr to different log message.

Expected behavior

1. Message should not be duplicated to /var/log/noobaa.log and /var/log/messages
2. journal have rate limit for the messages(20,000 message per 10mnts), Once we stop sending message to journal this bottleneck can be avoided.

Steps to reproduce

1. Install RPM and verify noobaa logs in /var/log/messages and /var/log/noobaa.log

More information - Screenshots / Logs / Other output

[naveenpaul1]

@guymguym @romayalon all the log messages are duplicated in both /logs/message and /logs/noobaa.log file. debug_module.log_internal() method writing logs to console using stderr or console after passing it to syslog. And these console logs are collected by imjournal and added to /logs/message log file. its fine for local testing but RPM its not that needed.
One solution would be set a config property to control these logs writing to the console. Logs will print added to console if its enabled, Something like this.

log_internal(msg_info) {
        if (syslog) {
            // syslog path
            syslog(this._levels_to_syslog[msg_info.level], msg_info.message_syslog, config.DEBUG_FACILITY);
        } else if (this._log_file) {
            // rotating file steam path (non browser)
            this._log_file.write(msg_info.message_file + os.EOL);
        }
        if (!config.ENABLE_WRITE_LOGS_TO_CONSOLE) return;   <---- New property to avoid log printing to console.
        // This is also used in order to log to the console
        // browser workaround, don't use rotating file steam. Add timestamp and level
        const logfunc = LOG_FUNC_PER_LEVEL[msg_info.level] || 'log';
        if (this._log_console_silent) {
            // noop
        } else if (console_wrapper) {
            process.stderr.write(msg_info.message_console + '\n');
        } else {
            console[logfunc](...msg_info.message_browser);
        }
        if (console_wrapper) {
            console_wrapper.wrapper_console();
        }
    }```