@liranmauda does this build successfully on mac arm64 now?

@liranmauda does this build successfully on mac arm64 now?

I have managed to build it on my mac (M1)

@liranmauda It fails on mac with node for arm64.

We need to add a condition to the mac section to handle node_arch=x64 vs arm64 like we do for linux.

In the isa-l readme and makefile it shows that on arm the toolchain to use is gcc/gas.
However when I tried it I had some issues on my mac so it might need more configuration to work out.

If you want we can merge this anyway to start running regression with the updated code, and fix the mac arm build in next PR.

@liranmauda It fails on mac with node for arm64.

We need to add a condition to the mac section to handle node_arch=x64 vs arm64 like we do for linux.

In the isa-l readme and makefile it shows that on arm the toolchain to use is gcc/gas. However when I tried it I had some issues on my mac so it might need more configuration to work out.

If you want we can merge this anyway to start running regression with the updated code, and fix the mac arm build in next PR.

@guymguym I agree, probably we need to do the same as in the Linux.
We can merge this so the code will be there and run.

I will rebase, and when it is approved I will merge it.