Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NSFS | NC | Manage NSFS | Invalid Flags Combination Is Ignored (Could Throw an Error) #7918

Closed
shirady opened this issue Mar 20, 2024 · 0 comments · Fixed by #8073
Closed

NSFS | NC | Manage NSFS | Invalid Flags Combination Is Ignored (Could Throw an Error) #7918

shirady opened this issue Mar 20, 2024 · 0 comments · Fixed by #8073
Assignees
@shirady
Labels
Non Containerized Non containerized NS-FS Request Validation Type:Enhancement New suggestions for behaviours
Milestone
5.17.0

Comments

@shirady
Copy link
Contributor

shirady commented Mar 20, 2024 •
edited

Environment info

  • NooBaa Version: master
  • Platform: NC

Actual behavior

  1. Invalid flags combination is ignored, for example:
    • --show_secrets without wide in the account list (--show_secrets is ignored).
    • --user with --gid and --uid (gid and uid are ignored).

Expected behavior

  1. Invalid flags combination could be checked and returned an error.

Steps to reproduce

  1. sudo node src/cmd/manage_nsfs account list --show_secrets (without --wide)
  2. sudo node src/cmd/manage_nsfs account add --name <account-name> --uid <uid> --gid <gid> --user root (with user and uid + gid)

More information - Screenshots / Logs / Other output

none
@shirady shirady added Type:Enhancement New suggestions for behaviours NS-FS Non Containerized Non containerized labels Mar 20, 2024
@nimrod-becker nimrod-becker modified the milestones: 5.16.z, 5.17.0 May 22, 2024
@shirady shirady self-assigned this May 23, 2024
@shirady shirady mentioned this issue May 23, 2024
Merged
2 tasks
@shirady shirady changed the title NSFS | NC | Manage NSFS | Invalid Flags Combination Is Ignored (Could Send an Error) NSFS | NC | Manage NSFS | Invalid Flags Combination Is Ignored (Could Throw an Error) May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shirady shirady

Labels
Non Containerized Non containerized NS-FS Request Validation Type:Enhancement New suggestions for behaviours
Projects
None yet
Milestone
5.17.0
Development

Successfully merging a pull request may close this issue.

NSFS | NC | Add Validate Flags Combination shirady/noobaa-core
2 participants
@nimrod-becker @shirady