New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The callbacks should contain context of the plugin #13

Open

anevins12 opened this issue Feb 24, 2017 · 0 comments

Contributor

anevins12 commented Feb 24, 2017

Callbacks are called without the context of the plugin and so it can be difficult to find the correct instance when running the callback.

Recommendation:
Add either 'self' or 'this' depending on the method as the callback argument.

E.g.:
this.options.callbackDestroy(this);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment