Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correction errors found #67

Open
BertheasLeo opened this issue Jul 8, 2022 · 1 comment
Open

Correction errors found #67

BertheasLeo opened this issue Jul 8, 2022 · 1 comment
Assignees
Labels

Comments

@BertheasLeo
Copy link
Contributor

BertheasLeo commented Jul 8, 2022

Hello,

We found 2 errors in the source code.

The first one is due to an error in compilation on windows where sighandler is not defined.
We need to add in eo/src/eoSIGContinue.h (line 36) :

#include <csignal>
typedef void (*sighandler_t)(int);
#include "eoContinue.h"

The second one was observed during test on the CMAES algorithm where the solution was converging on a area and at a certain point got a switched and diverged a lot without success to reconverging on a area. We found out that it was due to the covaraince matrix where an utilisation of a eigen fonction wasn't working as it has to be with like it seems to be an "aliasing issue".
So in edo/src/edoEstimatorNormalAdaptive.h (line 236):

Matrix mD = eigensolver.eigenvalues().asDiagonal();
// from variance to standard deviations
// Correction
mD = mD.cwiseSqrt();

Thanks

Best regards

@nojhan nojhan self-assigned this Aug 9, 2022
@nojhan nojhan added the bug label Aug 9, 2022
@nojhan
Copy link
Owner

nojhan commented Aug 9, 2022

Thanks.
The fix being easy to do, don't you want to make a pull request, so as to be credited?
Or do you prefer me to do it on your behalf?
Or just do it myself and not crediting you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants