fix: catch exceptions in fallback functions #510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a fallback function is called and throws an exception, the circuit breaker should catch the exception and return a rejected Promise. See: nodeshift#509 Signed-off-by: Lance Ball <lball@redhat.com>
Merged
lholmquist
approved these changes
Dec 7, 2020
There was a problem hiding this comment.
LGTM, @lance thoughts on needing a major release for this? I don't think so, but i can see an argument for needing it. although, it is just fixing what should have been there
|
I think it's really more of a bug fix... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a fallback function is called and throws an exception, the circuit
breaker should catch the exception and return a rejected Promise.
See: #509
Signed-off-by: Lance Ball lball@redhat.com