feat: allow pulling s2i image from image stream #639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make it possible to use an image stream to get the base s2i image used. Useful if a user needs to extend an s2i image when using OpenShift. Signed-off-by: Michael Dawson <mdawson@devrus.com>
lholmquist
reviewed
May 18, 2022
index.d.ts
Outdated
| @@ -86,6 +86,7 @@ export function deploy(options?: { | |||
| }; | |||
| resourceProfile?: string; | |||
| imageTag?: string; | |||
| ImageStram?: string; | |||
lholmquist
approved these changes
May 18, 2022
mhdawson
commented
May 19, 2022
|
@lholmquist coveralls has been doing some strange things related to reporting coverage |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make it possible to use an image stream to get
the base s2i image used. Useful if a user needs
to extend an s2i image when using OpenShift.
Signed-off-by: Michael Dawson mdawson@devrus.com