Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add typescript typings #577

Merged
merged 2 commits into from
Jul 28, 2021
Merged

feat: add typescript typings #577

merged 2 commits into from
Jul 28, 2021

Conversation

lholmquist
Copy link
Member

This adds typesctript types based on the JSDoc

@lholmquist lholmquist requested a review from a team July 27, 2021 17:42
@coveralls
Copy link

coveralls commented Jul 27, 2021 •
edited

Coverage Status

Coverage remained the same at 98.178% when pulling 8477dd0 on lholmquist:typescript-types-dip into b20701e on nodeshift:main.

mhdawson
mhdawson approved these changes Jul 27, 2021
View reviewed changes
Copy link
Contributor

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

danbev
danbev suggested changes Jul 28, 2021
View reviewed changes
index.d.ts Outdated Show resolved Hide resolved
index.d.ts Outdated Show resolved Hide resolved
index.d.ts Outdated Show resolved Hide resolved
@lholmquist lholmquist requested a review from danbev July 28, 2021 13:38
@lholmquist lholmquist merged commit e6f09f5 into nodeshift:main Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danbev danbev danbev approved these changes

@helio-frota helio-frota helio-frota approved these changes

@mhdawson mhdawson mhdawson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@lholmquist @coveralls @danbev @helio-frota @mhdawson