Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding package-support.json to the files array #566

Merged
merged 2 commits into from
Jun 1, 2021
Merged

Adding package-support.json to the files array #566

merged 2 commits into from
Jun 1, 2021

Conversation

aalykiot
Copy link
Member

@aalykiot aalykiot commented Jun 1, 2021

No description provided.

lholmquist
lholmquist approved these changes Jun 1, 2021
View reviewed changes
Copy link
Member

@lholmquist lholmquist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, i keep forgetting about htis

@lholmquist
Copy link
Member

@alexalikiotis look like you just need to fix that failing test

@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.389% when pulling c9e1ce7 on alexalikiotis:package-support into 68fddce on nodeshift:main.

@lholmquist lholmquist merged commit dfb6c37 into nodeshift:main Jun 1, 2021
@pacostas pacostas mentioned this pull request Feb 2, 2023
Closed
@lholmquist lholmquist mentioned this pull request Jul 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lholmquist lholmquist lholmquist approved these changes

@richardlau richardlau richardlau approved these changes

@helio-frota helio-frota Awaiting requested review from helio-frota

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@aalykiot @lholmquist @coveralls @richardlau