Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add exposeHost option #558

Merged
merged 2 commits into from
May 7, 2021
Merged

add exposeHost option #558

merged 2 commits into from
May 7, 2021

Conversation

mzellho
Copy link
Contributor

@mzellho mzellho commented May 6, 2021 •
edited

When using export, a Route is generated, but there was no way to define
the Alias/DNS that points to the service.

@mzellho
add exposeHost option
b134185 
When using export, a Route is generated, but there was no way to define
the hostname for the route.
@mzellho
fix docs
a86911d
@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.389% when pulling a86911d on mzellho:exposeHost into 443c24c on nodeshift:main.

lholmquist
lholmquist approved these changes May 7, 2021
View reviewed changes
Copy link
Member

@lholmquist lholmquist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the Contribution

@lholmquist lholmquist merged commit 497f8d3 into nodeshift:main May 7, 2021
@lholmquist
Copy link
Member

released as 8.2.0

@mzellho mzellho deleted the exposeHost branch May 10, 2021 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lholmquist lholmquist lholmquist approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mzellho @coveralls @lholmquist