Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use passed in credentials to deploy instead of getting the local kube config #524

Merged
merged 8 commits into from
Jan 8, 2021

Conversation

lholmquist
Copy link
Member

@lholmquist lholmquist commented Jan 6, 2021

The openshiftt Rest client already has the ability to specify a username/password/api server url combo instead of using the default ~/.kube/config file.

This PR adds the ability to now pass those options in through the cli and API

New options added:

username, password , apiServer and insecure.

Since this flow doesn't get any existing kube configs that might be local, it will not get the current namespace/project that a user might be on. So by default it will just use the default namespace, but by using the namespace flag, it can easily be changed.

If using Code Ready Containers(CRC), the cli command might look something like this:

$ nodeshift --apiServer https://api.crc.testing:6443 --username developer --password developer --insecure --namespace.name nodejs-examples

Still need to add tests and update the readme as well as not hard code the insecureTLSVerify variable for self-signed certs

@coveralls
Copy link

coveralls commented Jan 6, 2021

Coverage Status

Coverage increased (+0.01%) to 98.626% when pulling 0fb393b on lholmquist:NODE-885-login-with-creds into 9027eea on nodeshift:master.

@lholmquist lholmquist marked this pull request as ready for review January 7, 2021 18:47
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
lholmquist and others added 2 commits January 8, 2021 09:47
Co-authored-by: Helio Frota <00hf11@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants