Fixed: not returning coroutine job. Increased version to 2.3.1

ml-archive · Feb 5, 2019 · 5c9092a · 5c9092a
1 parent 5363e11
commit 5c9092a
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 8 deletions.
diff --git a/app/build.gradle b/app/build.gradle
@@ -9,7 +9,7 @@ android {
         minSdkVersion 19
         targetSdkVersion 28
         versionCode 6
-        versionName "2.3.0"
+        versionName "2.3.1"
         testInstrumentationRunner "android.support.test.runner.AndroidJUnitRunner"
     }
     buildTypes {

diff --git a/app/maven-push.gradle b/app/maven-push.gradle
@@ -12,7 +12,7 @@ allprojects { ext."signing.password" = System.getenv('password') }
 
 // Artifact settings
 def _group = 'dk.nodes.arch'
-def _version = '2.3.0'
+def _version = '2.3.1'
 def _archivesBaseName = 'base'
 
 def _name = 'Nodes Architecture Library'

diff --git a/app/src/main/java/dk/nodes/arch/presentation/base/BasePresenterImpl.kt b/app/src/main/java/dk/nodes/arch/presentation/base/BasePresenterImpl.kt
@@ -108,16 +108,16 @@ abstract class BasePresenterImpl<V> : BasePresenter<V>, LifecycleObserver {
         defaultCoroutineContext = mainThreadSurrogate + job
     }
 
-    fun launchOnUI(block: suspend CoroutineScope.() -> Unit) {
-        mainScope.launch(context = mainCoroutineContext, block = block)
+    fun launchOnUI(block: suspend CoroutineScope.() -> Unit): Job {
+        return mainScope.launch(context = mainCoroutineContext, block = block)
     }
 
-    fun launchOnIO(block: suspend CoroutineScope.() -> Unit) {
-        ioScope.launch(context = mainCoroutineContext, block = block)
+    fun launchOnIO(block: suspend CoroutineScope.() -> Unit): Job {
+        return ioScope.launch(context = mainCoroutineContext, block = block)
     }
 
-    fun launch(block: suspend CoroutineScope.() -> Unit) {
-        defaultScope.launch(context = defaultCoroutineContext, block = block)
+    fun launch(block: suspend CoroutineScope.() -> Unit): Job {
+        return defaultScope.launch(context = defaultCoroutineContext, block = block)
     }
 
     fun <T> asyncOnUI(block: suspend CoroutineScope.() -> T): Deferred<T>  {