Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

draft documentation promotion #373

Closed
7 of 8 tasks
thescientist13 opened this issue Jun 16, 2020 · 7 comments · Fixed by #500
Closed
7 of 8 tasks

draft documentation promotion #373

thescientist13 opened this issue Jun 16, 2020 · 7 comments · Fixed by #500
Assignees
Labels
article Need to spread this information good first issue Good for newcomers help wanted Extra attention is needed package-maintenance-agenda Agenda items for package-maintenance team

Comments

@thescientist13
Copy link
Contributor

thescientist13 commented Jun 16, 2020

We have a number of docs in draft status, but not sure what is left or needed. They should probably all be reviewed and if complete "enough" should probably be at least moved into the top level docs folder.

This is a top level tracking item to promote them all

Note: they should also have the "draft" status removed from their listing in the Table of Contents.

@thescientist13 thescientist13 added help wanted Extra attention is needed good first issue Good for newcomers labels Jun 16, 2020
@thescientist13 thescientist13 changed the title draft documentation draft documentation promotion Jun 16, 2020
@thescientist13 thescientist13 added the article Need to spread this information label Jun 16, 2020
@ghinks
Copy link
Contributor

ghinks commented Jun 24, 2020

@thescientist13 thank you Owen, this does seem like something that I have time for. I'll look at the testing draft by @Eomm over the next week, make comments and get back.

@ghinks
Copy link
Contributor

ghinks commented Jul 10, 2020

@thescientist13 I think the testing document is going well and we are only waiting on a few more reviews. It is a basic document but there are quite distinct schools of thought about testing.
I would like to move onto the CI/CD document. @dominykas mentioned in the testing document review that we need real world methodologies of how and where we can do CI/CD for open source. I agree and I'll link the testing document to the CI/CD document once we get it written.

For myself I do not know quite enough to start this yet and want to talk in the next package maintenance meeting. What we need are a bunch of projects in opensource that do this so we have concrete examples.

@thescientist13
Copy link
Contributor Author

thescientist13 commented Jul 11, 2020

Hey @ghinks , and sounds good to me. Maybe we should add the agenda label to #340 and then we can discuss it on the call this week? Happy to help contribute ideas and topics for the document as well. 👍

@ghinks
Copy link
Contributor

ghinks commented Jul 28, 2020

@thescientist13 the testing doc is looking good and there is only one other re-review by @bnb to come in. I wanted to make a start on the CI/CD document. The feedback is we need real examples and so I have been working, as a part of the expressJS triage team, to learn how to carry out full CI/CD on the GitHub actions platform. I have been working in an integration test repo so that we have some hard examples of not just regular unit test and lint operations but we have npm and docker image publication then integration tests using those images.

@lholmquist
Copy link
Contributor

should the deprecation guidelines also be part of the promotion list?

@thescientist13
Copy link
Contributor Author

@lholmquist that
Oh yes, good call. I suppose an issue should be made for that one as well... so done and added! ( #431)

@jonchurch
Copy link
Contributor

I'd love to see our best practices be living documents. I think it's a good idea to promote most of these and just keep updating them as necessary, to lower the inertia around publishing only when they're "done".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
article Need to spread this information good first issue Good for newcomers help wanted Extra attention is needed package-maintenance-agenda Agenda items for package-maintenance team
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

4 participants