Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seperating the title with the subcontent in about (Sidebar) #6677

Closed
TenzDelek opened this issue Apr 28, 2024 · 5 comments · Fixed by #6678
Closed

Seperating the title with the subcontent in about (Sidebar) #6677

TenzDelek opened this issue Apr 28, 2024 · 5 comments · Fixed by #6678
Labels
accessibility Issues concerning accessibility design

Comments

@TenzDelek
Copy link
Contributor

URL:

https://nodejs.org/en/about

Browser Name:

brave

Browser Version:

1.65.123

Operating System:

Windows 11

How to reproduce the issue:

  1. Go the about
    the current visual looks like this
image image

i notice a visual dissatisfaction with the title and the subpart of it . i feel like there should be more separation between them (not only making the font small we can try the below idea )
solution:

  1. either darken out the title a little bit to show a contrast to it
  2. or we can add a padding left to the subpart to show seperation
@TenzDelek TenzDelek added the bug label Apr 28, 2024
@TenzDelek
Copy link
Contributor Author

solution : example for the first one :
image
for the second one:
image

@AugustinMauroy
Copy link
Contributor

I allow it's not 100% clear but I thinks the best things it's just to add bottom border to the title.

@AugustinMauroy AugustinMauroy added accessibility Issues concerning accessibility design and removed bug labels Apr 28, 2024
@TenzDelek
Copy link
Contributor Author

@AugustinMauroy ya the border bottom one sounds good, will create a pr for it

@ovflowd
Copy link
Member

ovflowd commented Apr 29, 2024

It's subject to personal interpretation. For me, it is already clear that one is a section title and the latter are section entries. I also believe that the suggestions aren't really good ones.

I'm not even sure this is an accessibility issue, @AugustinMauroy why did you mark it as a accessibility issue?

@AugustinMauroy
Copy link
Contributor

I'm not even sure this is an accessibility issue, @AugustinMauroy why did you mark it as a accessibility issue?

I made this choice because the issue isn't a bug (unexpected behaviour) but a problem of readability and the level of highlighting of elements

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Issues concerning accessibility design
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants