Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix breadcrumbs to the top of learn page #6655

Closed
wants to merge 1 commit into from

Conversation

dtsuper3
Copy link

@dtsuper3 dtsuper3 commented Apr 14, 2024

Fixes #6651

Description

I have relocated the breadcrumbs to the top section.

Validation

Related Issues

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npx turbo format to ensure the code follows the style guide.
  • I have run npx turbo test to check if all tests are passing.
  • I have run npx turbo build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

@dtsuper3 dtsuper3 requested a review from a team as a code owner April 14, 2024 09:54
Copy link

vercel bot commented Apr 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Apr 14, 2024 9:56am

@ovflowd
Copy link
Member

ovflowd commented Apr 14, 2024

I wouldn't create PRs for things that haven't been decided yet. There's a high chance this won't get merged at all.

@dtsuper3
Copy link
Author

@ovflowd Could you please check again? I forgot to include the link to the open issue.

@ovflowd
Copy link
Member

ovflowd commented Apr 14, 2024

@ovflowd Could you please check again? I forgot to include the link to the open issue.

I'm not sure what you mean by this comment. The issue you're referring to is a discussion that had 0 replies yet. This means we won't proceed with your PR before the Website team reaches a consensus.

In other words, I'm just advising you that the time you've spent on this PR might be in vain, as this PR is not guaranteed to get merged... At all. 😅

@dtsuper3 dtsuper3 closed this Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider moving the breadcrumbs to the top of the page in nodejs/learn section
2 participants