Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update h1 so that it is visible #6605

Closed
wants to merge 2 commits into from
Closed

Update h1 so that it is visible #6605

wants to merge 2 commits into from

Conversation

mikolertesx
Copy link

Description

Removed web-text-fill-color:transparent.

Validation

Select the title text, and click outside the browser so that it looses focus.

Before
imagen

After
imagen

Related Issues

Fixes #6585

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npx turbo format to ensure the code follows the style guide.
  • I have run npx turbo test to check if all tests are passing.
  • I have run npx turbo build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

@mikolertesx mikolertesx requested a review from a team as a code owner April 3, 2024 01:06
@vercel Vercel
Copy link

vercel bot commented Apr 3, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Apr 3, 2024 8:08pm

@mikolertesx mikolertesx mentioned this pull request Apr 3, 2024
Open
AugustinMauroy
AugustinMauroy requested changes Apr 3, 2024
View reviewed changes
Copy link
Contributor

@AugustinMauroy AugustinMauroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to found another solution because it's break the gradient effect on safari.

@AugustinMauroy
Copy link
Contributor

@mikolertesx I think your solution work for you (I'm not able to reproduce your issue on my machine)

@AugustinMauroy AugustinMauroy added the github_actions:pull-request Trigger Pull Request Checks label Apr 3, 2024
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Apr 3, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 3, 2024 •
edited

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟠 88 🟢 96 🟢 100 🟢 91 🔗
/en/about 🟢 99 🟢 96 🟢 100 🟢 91 🔗
/en/about/previous-releases 🟢 98 🟢 95 🟢 100 🟢 92 🔗
/en/download 🟢 99 🟢 95 🟢 96 🟢 91 🔗
/en/blog 🟢 98 🟢 96 🟢 100 🟢 92 🔗

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 3, 2024

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 91%
 89.68% (574/640) 75.1% (175/233) 91.4% (117/128)

Unit Test Report

Tests Skipped Failures Errors Time
120 0 💤 0 ❌ 0 🔥 5.45s ⏱️

@mikolertesx
Copy link
Author

@mikolertesx I think your solution work for you (I'm not able to reproduce your issue on my machine)

No, I made a mistake, since you have to re-run the app so that CSS compiles again.

This is a way more complicated issue than I originally thought.
I can't fix it with my current knowledge.

I have to remove -webkit-text-fill-color so that it doesn't remove the text on Firefox. But doing so breaks Safari.

I imagine something can be done with ::before, and ::after.

@mikolertesx
Copy link
Author

I'll close this if you don't mind.

@mikolertesx mikolertesx closed this Apr 3, 2024
@ovflowd
Copy link
Member

ovflowd commented Apr 3, 2024

No, I made a mistake, since you have to re-run the app so that CSS compiles again.

Only the global styles, apparently. For some reason (no idea why HMR is not working there, we should probably open an issue)

I have to remove -webkit-text-fill-color so that it doesn't remove the text on Firefox. But doing so breaks Safari.

Indeed it is a complex issue :melt:

@mikolertesx
Copy link
Author

This would also be my first open-source contribution, I'm just not ready for this haha. 😤

@AugustinMauroy
Copy link
Contributor

This would also be my first open-source contribution, I'm just not ready for this haha. 😤

you're welcome to make another contribution. Unfortunately, you've come across some very strange behaviour.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AugustinMauroy AugustinMauroy AugustinMauroy requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Run Javascript Anywhere" invisible when text is selected in dark mode
3 participants
@mikolertesx @AugustinMauroy @ovflowd