Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(banner): take place on screen, should we add the possibility of hide #6292

Open
AugustinMauroy opened this issue Feb 8, 2024 · 2 comments
Labels
ideas website redesign Issue/PR part of the Node.js Website Redesign

Comments

@AugustinMauroy
Copy link
Contributor

AugustinMauroy commented Feb 8, 2024

Problem / situation

When I reviewed the pr, I was 'bothered' by the banner, which took up a lot of space. In some doc creation tools such as Docusaurus, Nextra there is a way to hide the banner to maximise the space dedicated to the content you are reading.

This is what the "learn" section looks like when there is a banner.

Capture d’écran 2024-02-08 à 09 02 02

A possible solution

One possible solution is to put a small cross at the far right of the banner. This cross hides the way, but if there is a new banner, it must be displayed.

code already done

NOTE: to run the website with new design do turbo serve:redesign

@AugustinMauroy AugustinMauroy added ideas website redesign Issue/PR part of the Node.js Website Redesign labels Feb 8, 2024
@bmuenzenmeyer
Copy link
Collaborator

I think this is a well-thought out concern - and one you even raised in the Figma 5 months ago

agree this is standard functionality for many tools

we need to weigh the cost vs the intent

  • we only use the banner for VERY important things, like a security release
  • do we do so for every new version? doubtful
  • dismissable banners need to persist, and cache bust via a key

I doubt we'll get Hayden's input on this as he's moved on - so, what do others think? I'm on the fence about adding it right now - before the site is even live.

@AugustinMauroy
Copy link
Contributor Author

we only use the banner for VERY important things, like a security release

Yes, I'll use an example to explain the problem. Let's say we click on the banner. This means that the user is reading the article, so the banner doesn't do anything for him apart from taking up screen space and mental workload.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ideas website redesign Issue/PR part of the Node.js Website Redesign
Projects
Status: 📋 Backlog
Development

No branches or pull requests

2 participants