Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

benchmark: Fix crash in net benchmarks #6407

Closed
wants to merge 1 commit into from
Closed

benchmark: Fix crash in net benchmarks #6407

wants to merge 1 commit into from

Conversation

matthewloring
Copy link

@matthewloring matthewloring commented Apr 27, 2016

Checklist
  • tests and code linting passes
    • test-tick-processor/test-domain-no-error-handler-abort-on-uncaught
      are failing but these should be unrelated.
  • a test and/or benchmark is included
  • the commit message follows commit guidelines
Affected core subsystem(s)

benchmark

Description of change

Net benchmarks create partial event emitters that do not have all of the
required event emitter functions. They currently mock out on, once,
and emit functions. This change mocks out prependListener as well to
avoid crashing in _stream_readable.

Fixes #6405

Net benchmarks create partial event emitters that do not have all of the
required event emitter functions. They currently mock out `on`, `once`,
and `emit` functions. This change mocks out `prependListener` as well to
avoid crashing in `_stream_readable`.

Fixes #6405
@matthewloring matthewloring added events Issues and PRs related to the events subsystem / EventEmitter. benchmark Issues and PRs related to the benchmark subsystem. labels Apr 27, 2016
@matthewloring matthewloring self-assigned this Apr 27, 2016
@addaleax
Copy link
Member

LGTM

test-tick-processor/test-domain-no-error-handler-abort-on-uncaught are failing but these should be unrelated.

it is.

@mscdex
Copy link
Contributor

mscdex commented Apr 27, 2016

@jasnell
Copy link
Member

jasnell commented Apr 27, 2016

LGTM

1 similar comment
@JungMinu
Copy link
Member

LGTM

@matthewloring
Copy link
Author

Could we address #6405 (comment) in a follow PR or should we set up a way to optionally run benchmarks for correctness in the CI here?

@matthewloring
Copy link
Author

Landed in 89164a0

@MylesBorins
Copy link
Member

@matthewloring should this be backported?

@matthewloring matthewloring deleted the ee-prepend branch June 1, 2016 23:52
@matthewloring
Copy link
Author

Probably not a big deal since these benchmarks will be run from source and not from a distribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
benchmark Issues and PRs related to the benchmark subsystem. events Issues and PRs related to the events subsystem / EventEmitter.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants