Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop visual studio 2015 support in CI #37472

Closed
gengjiawen opened this issue Feb 22, 2021 · 7 comments
Closed

drop visual studio 2015 support in CI #37472

gengjiawen opened this issue Feb 22, 2021 · 7 comments
Labels
build Issues and PRs related to build files or the CI. windows Issues and PRs related to the Windows platform.

Comments

@gengjiawen
Copy link
Member

It seems building addons with VS2015 is not working now. Unfortunately the build output doesn't seem to contain useful information.

I thought we only support Visual Studio >= 2017 now in node-gyp.

Also, looks like this is the reason
https://ci.nodejs.org/job/node-test-binary-windows-native-suites/7515/nodes=win10-vcbt2015-COMPILED_BY-vs2019/console

16:08:09     `C:\\workspace\\node-test-binary-windows-native-suites\\node\\deps\\v8\\include\\v8.h(1426): error C2416: attribute 'deprecated("Use constructor with primitvie C++ types")' cannot be applied in this context [C:\\workspace\\node-test-binary-windows-native-suites\\node\\test\\addons\\02_function_arguments\\build\\addon.vcxproj]\r\n`

Not sure node\\test\\addons\\02_function_arguments locations.

Originally posted by @gengjiawen in #37330 (comment)

@gengjiawen
Copy link
Member Author

gengjiawen commented Feb 22, 2021

cc @targos @nodejs/build-infra @nodejs/node-gyp @nodejs/platform-windows

@richardlau
Copy link
Member

Refs: https://github.com/nodejs/build/blob/master/doc/windows-visualstudio-supported-versions.md

cc @joaocgreis

@gengjiawen
Copy link
Member Author

And I am thinking For building Node.js Addons only support 2019 in upcoming v16.

@joaocgreis
Copy link
Member

For building addons, it's good to support as many versions as we can. Someone with VS2017 installed would have to upgrade to VS2019, and this can be a big issue for some users. But of course, this has to be balanced with our ability to maintain it.

Note that dropping a VS version includes editing BUILDING.md, updating CI, and adjusting node-gyp (see https://github.com/nodejs/node-gyp/blob/a78b584236e92a9469f72916c55ba83e9819ddea/lib/find-visualstudio.js#L348-L352).

@targos targos added build Issues and PRs related to build files or the CI. windows Issues and PRs related to the Windows platform. labels Aug 9, 2021
@targos
Copy link
Member

targos commented Oct 5, 2022

I'd like to revisit this for Node.js 19 / V8 10.7

See #44741

@gengjiawen
Copy link
Member Author

I'd like to revisit this for Node.js 19 / V8 10.7

See #44741

tbh,I want to drop 2017 too. Since MSVC not fixing bugs timely or give useful feedback.

@targos
Copy link
Member

targos commented Oct 7, 2022

PR in node-gyp: nodejs/node-gyp#2746
PR in build: nodejs/build#3049

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. windows Issues and PRs related to the Windows platform.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants