New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mutable default arguments in Python code #3005

Open

artshipulin opened this issue Apr 2, 2024 · 1 comment

Labels

Waiting For Input

artshipulin commented Apr 2, 2024

node-gyp/gyp/pylib/gyp/common.py

Line 456 in f90ce12

def CopyTool(flavor, out_path, generator_flags={}):

is wrong because https://docs.python-guide.org/writing/gotchas/#mutable-default-arguments

Contributor

cclauss commented Apr 2, 2024 •

edited

Pull requests are gladly reviewed on the repo https://github.com/nodejs/gyp-next

Please look to see if there are any others by running ruff check --select=B006

Also, try ruff rule B006

https://docs.astral.sh/ruff/rules/mutable-argument-default

cclauss added the Waiting For Input label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment