Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: README.md Do not hardcode the supported versions of Python #2880

Merged
merged 2 commits into from Aug 25, 2023
Merged

docs: README.md Do not hardcode the supported versions of Python #2880

merged 2 commits into from Aug 25, 2023

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Jun 29, 2023 •
edited

Fixes: #2879
Fixes: #2881

Python 3.7 went end-of-life this week.

Also,

  • ruff --ignore=E721
  • Lint_Python takes ~5 seconds, so wait for it to pass before running the full matrix of tests.
  • Remove outdated macOS_Catalina.md file.
  • Replace deprecated npm config set python with environment variable npm_config_python.
Checklist
  • npm install && npm test passes
  • tests are included
  • documentation is changed or added
  • commit message follows commit guidelines
Description of change

README.md Do not hardcode the supported versions of Python

@cclauss cclauss force-pushed the Do-not-hardcode-the-supported-versions-of-Python branch 2 times, most recently from 2e3b303 to 342eb4d Compare July 24, 2023 11:09
@cclauss cclauss force-pushed the Do-not-hardcode-the-supported-versions-of-Python branch 2 times, most recently from 9d8e177 to c295082 Compare August 25, 2023 09:59
@cclauss cclauss force-pushed the Do-not-hardcode-the-supported-versions-of-Python branch from bf374eb to 277760c Compare August 25, 2023 10:33
@gengjiawen gengjiawen merged commit bb93b94 into main Aug 25, 2023
13 of 22 checks passed
@gengjiawen gengjiawen deleted the Do-not-hardcode-the-supported-versions-of-Python branch August 25, 2023 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gengjiawen gengjiawen gengjiawen approved these changes

@rvagg rvagg Awaiting requested review from rvagg

@lukekarrys lukekarrys Awaiting requested review from lukekarrys

@cjihrig cjihrig Awaiting requested review from cjihrig

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

issue with npm 9.x.x: python is not a valid npm option Drop npm config set support
2 participants
@cclauss @gengjiawen