feat: remove support for VS2015 in Node.js >=19 #2746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @nodejs/build @nodejs/npm @nodejs/releasers We will need to coordinate an npm release with this change, its inclusion in v19.0.0, and adaptations to the Node.js CI. |
|
I think this is something we should do regardless of issues with V8, to prepare users for Node.js 20. Visual Studio 2015 will be out of support on Oct 14, 2025, before the 20.x EoL. |
RafaelGSS
approved these changes
Oct 7, 2022
sxa
approved these changes
Oct 7, 2022
Trott
approved these changes
Oct 7, 2022
richardlau
approved these changes
Oct 7, 2022
|
I thought about it but since it only applies to an unreleased version of node, I thought it could not really break anyone |
|
But feel free to land as breaking, I have no strong opinion on that |
|
Ah good point about it referring to an unreleased version. I'm okay with it landing just as a feat (i.e. Node.js 19 support). |
gengjiawen
approved these changes
Oct 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: nodejs/node#37472