feat: Update function getSDK() to support Windows 11 SDK #2565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please note that the failing tests do not fail locally on my development machine, therefore I am not able to debug. Would help, if someone else could look at the failing test. |
|
@nodejs/node-gyp |
Any machine on CI we can test this ? I have no win11 machine. |
|
@nodejs/platform-windows we probably need someone running a dev environment to help validate this |
|
Do you just need someone to run a normal build? If so I can set up my env outside WSL2 and give it a go. |
Mainly verify this works on windows 11 and fix #2527 |
|
Please note that it is not necessary to test this on Windows 11. The whole pull request is about supporting the Windows 11 SDK not Windows 11. You can use the Windows 11 SDK on Windows 10 as well. |
|
Status? |
|
Is there something that I can do to help get this finally done? |
|
It is working properly on my local. Can this be merged to the codebase please or is there anything else missing? |
|
I confirm that this works on my system.
Why is this not merged yet? It has been two months. |
|
@SpecialAro @mavaddat @namazso Any GitHub user has the right to review and approve any pull request. Doing so gives maintainers confidence the code has been examined, tested, and found to be beneficial. Pull requests that have lots of approvals are much more compelling to maintainers than pull requests that have none. If you agree, please do the following:
|
mavaddat
approved these changes
Jun 30, 2022
There was a problem hiding this comment.
Works on my System:
| Field | Value |
|---|---|
| OsVersion | 10.0.25145 |
| WindowsCurrentVersion | 6.3 |
| WindowsVersion | 2009 |
[
{
"path": "C:\\Program Files\\Microsoft Visual Studio\\2022\\Preview",
"version": "17.3.32611.2",
"packages": [
"Microsoft.VisualStudio.Product.Community",
"Microsoft.VisualStudio.PackageGroup.LiveShare.VSCore",
"Microsoft.VisualStudio.LiveShare.VSCore",
"Microsoft.VisualStudio.Workload.NativeCrossPlat",
"Component.Linux.CMake",
"Microsoft.VisualStudio.VC.Ide.Linux.CMake",
"Microsoft.VisualStudio.Workload.Node",
"Microsoft.VisualStudio.Component.Node.Tools",
"Microsoft.VisualStudio.PackageGroup.JavaScript.NodeAdapterHost",
"Microsoft.VisualStudio.JavaScript.NodeAdapterHost",
"Microsoft.VisualStudio.JavaScript.NodeAdapter",
"Microsoft.VisualStudio.NodejsTools.TestAdapter",
"Microsoft.VisualStudio.NodejsTools.NodejsTools",
"Microsoft.VisualStudio.NodejsTools.Targets",
"Microsoft.VisualStudio.Workload.Python",
"Microsoft.VisualStudio.Component.VC.DiagnosticTools",
"Microsoft.VisualStudio.Component.Graphics.Tools",
"Microsoft.VisualStudio.Component.VC.Tools.x86.x64",
"Microsoft.VisualCpp.CodeAnalysis.Extensions",
"Microsoft.VisualCpp.CodeAnalysis.Extensions.X86",
"Microsoft.VC.14.33.17.3.CodeAnalysis.Extensions.X86.base",
"Microsoft.VC.14.33.17.3.CodeAnalysis.X86.Res.base",
"Microsoft.VisualCpp.CodeAnalysis.Extensions.X64",
"Microsoft.VC.14.33.17.3.CodeAnalysis.Extensions.X64.base",
"Microsoft.VC.14.33.17.3.Servicing.CAExtensions",
"Microsoft.VC.14.33.17.3.CodeAnalysis.X64.Res.base",
"Microsoft.VisualCpp.Tools.HostX64.TargetX86",
"Microsoft.VC.14.33.17.3.Tools.HostX64.TargetX86.base",
"Microsoft.VC.14.33.17.3.Tools.HostX64.TargetX86.Res.base",
"Microsoft.VisualCpp.Tools.HostX64.TargetX64",
"Microsoft.VC.14.33.17.3.Tools.HostX64.TargetX64.base",
"Microsoft.VC.14.33.17.3.Tools.HostX64.TargetX64.Res.base",
"Microsoft.PackageGroup.Icecap.Core",
"Microsoft.Icecap.Analysis",
"Microsoft.Icecap.Analysis.Targeted",
"Microsoft.Icecap.Analysis.Resources",
"Microsoft.Icecap.Analysis.Resources.Targeted",
"Microsoft.NetCore.FSharp.ProjectTemplates.Test",
"Microsoft.NetCore.FSharp.ProjectTemplates",
"Microsoft.VisualStudio.Component.FSharp",
"Microsoft.FSharp.IDE",
"Microsoft.FSharp.Dependencies",
"Microsoft.FSharp.SDK",
"Microsoft.NetCore.Component.SDK",
"Microsoft.NET.Sdk.tvOS.Manifest-6.0.400",
"Microsoft.NET.Sdk.macOS.Manifest-6.0.400",
"Microsoft.Mono.ToolChain.Manifest-6.0.300",
"Microsoft.NET.Workload.Emscripten.Manifest-6.0.300",
"Microsoft.NET.Sdk.Maui.Manifest-6.0.300",
"Microsoft.MacCatalyst.Manifest-6.0.400",
"Microsoft.NET.Sdk.iOS.Manifest-6.0.400",
"Microsoft.NET.Sdk.Android.Manifest-6.0.300",
"Microsoft.NetCore.TemplateLocator",
"Microsoft.Net.Core.SDK.MSBuildExtensions",
"Microsoft.NetStandard.TargetingPack.2.1.2.1.0",
"Microsoft.NetCore.Toolset.6.0.400-preview.22301.10",
"Microsoft.NetCore.HostPath",
"Microsoft.NetCore.SharedHost.6.0.0",
"Microsoft.VisualStudio.Component.NuGet",
"Microsoft.VisualStudio.NuGet.Licenses",
"Microsoft.VisualStudio.PackageGroup.WebToolsExtensions.MSBuild",
"Microsoft.VisualStudio.PackageGroup.WebToolsAzure",
"Microsoft.VisualStudio.Web.Azure",
"Microsoft.VisualStudio.Azure.CommonAzureTools",
"Microsoft.Publish.Framework",
"Azure.Storage.Emulator",
"Microsoft.VisualStudio.Component.TextTemplating",
"Component.Microsoft.ML.ModelBuilder",
"Microsoft.ML.ModelBuilder",
"Microsoft.VisualStudio.AppResponsiveness.Resources",
"Microsoft.Windows.UniversalCRT.Msu.8",
"Microsoft.VisualStudio.ScriptedHost",
"Microsoft.IntelliTrace.DiagnosticsHub",
"SQLiteCore",
"SQLiteCore.Targeted",
"Microsoft.VisualStudio.Graphics.Appid",
"Microsoft.VisualStudio.Debugger.Remote.DiagnosticsHub.Client",
"Microsoft.VisualStudio.Graphics.Appid.Resources",
"Microsoft.VisualStudio.VC.CMake.Client",
"Microsoft.VisualStudio.Component.Windows10SDK",
"Microsoft.VisualStudio.Component.VC.CoreIde",
"Microsoft.VisualStudio.VC.Ide.Pro",
"Microsoft.VisualStudio.VC.Ide.Pro.Resources",
"Microsoft.VisualStudio.VC.IDE.Project.Factories",
"Microsoft.VisualStudio.VC.Templates.General",
"Microsoft.VisualCpp.Premium.Tools.HostX86.TargetX64",
"Microsoft.VC.14.33.17.3.Premium.Tools.HostX86.TargetX64.base",
"Microsoft.NetCore.Component.DevelopmentTools",
"Microsoft.VisualStudio.HotReload.Components",
"Microsoft.VC.14.33.17.3.Prem.Hostx86.Targetx64.Res.base",
"Microsoft.VisualStudio.ClickOnce.Publish",
"Microsoft.VisualStudio.PackageGroup.DotNetCoreTemplates.CSharpVB",
"Microsoft.WindowsDesktop.TargetingPack.6.0.6.0.5",
"Microsoft.NetCore.HostFXR.6.0.5",
"Microsoft.NetCore.HostFXR.6.0.5",
"Microsoft.NetCore.SdkPlaceholder.6.0.400-preview.22301.10",
"Microsoft.WindowsDesktop.TargetingPack.6.0.6.0.5",
"Microsoft.VisualStudio.TestTools.TestPlatform.LocalFeed.msi",
"Microsoft.VisualStudio.Debugger.VsDbg.Integration",
"Microsoft.VisualStudio.VC.Ide.Linux.ConnectionManager",
"Microsoft.VisualStudio.VC.Ide.Linux.ConnectionManager.Resources",
"Microsoft.NetCore.SharedFramework.6.0.6.0.5",
"Microsoft.NetCore.SharedFramework.6.0.6.0.5",
"Microsoft.NetCore.AppHostPack.6.0.6.0.5.x86",
"Microsoft.NetCore.AppHostPack.6.0.6.0.5.x64",
"Microsoft.NetCore.AppHostPack.6.0.6.0.5.arm64",
"Microsoft.NetCore.AppHostPack.6.0.6.0.5.arm",
"Microsoft.AspNetCore.TargetingPack.6.0.6.0.5-servicing.22218.2",
"Microsoft.AspNetCore.TargetingPack.6.0.6.0.5-servicing.22218.2",
"Microsoft.AspNetCore.SharedFramework.6.0.6.0.5-servicing.22218.2",
"Component.MDD.Linux",
"Microsoft.VisualStudio.VC.Ide.Linux",
"Microsoft.VisualStudio.VC.Ide.Linux.Resources",
"Microsoft.VisualStudio.PackageGroup.TestTools.CodeCoverage",
"Microsoft.VisualStudio.PackageGroup.TestTools.DataCollectors",
"Microsoft.Net.ClickOnceBootstrapper",
"Microsoft.ClickOnce.BootStrapper.Msi.Resources",
"Microsoft.ClickOnce.BootStrapper.Msi",
"Microsoft.VisualStudio.PackageGroup.JavaScript.Language",
"Microsoft.VisualStudio.CodeSense.Community",
"Microsoft.VisualStudio.Package.NodeJs",
"Microsoft.VisualStudio.VC.Ide.SecurityIssueAnalysis.3rdPartyLibs.3",
"Microsoft.VisualStudio.Graphics.Msi",
"Microsoft.VisualStudio.VC.Templates.General.Resources",
"Microsoft.VisualStudio.VC.Items.Pro",
"Microsoft.Component.PythonTools",
"Microsoft.CookiecutterTools.Vsix",
"Microsoft.CookiecutterTools.Vsix.Resources",
"Microsoft.PythonTools.Profiling.Vsix",
"Microsoft.VisualStudio.VC.Ide.ATL",
"Microsoft.VC.14.33.17.3.ATL.X64.base",
"Microsoft.PythonTools.Profiling.Vsix.Resources",
"Microsoft.PythonTools.Core.Templates.Vsix",
"Microsoft.VisualStudio.IntelliCode",
"Microsoft.VisualStudio.Component.WslDebugging",
"Microsoft.VisualStudio.WslDebugging",
"Component.Microsoft.VisualStudio.LiveShare.2022",
"Microsoft.VisualStudio.Component.Debugger.JustInTime",
"Microsoft.VisualStudio.Debugger.ImmersiveActivateHelper.Msi",
"Microsoft.VisualStudio.Debugger.JustInTime",
"Microsoft.VisualStudio.Debugger.JustInTime.Msi",
"Microsoft.VisualStudio.LiveShare.2022",
"Microsoft.VisualStudio.Windows.Forms",
"Microsoft.VisualStudio.TemplateEngine",
"Microsoft.VisualCpp.Premium.Tools.HostX86.TargetX86",
"Microsoft.NetCore.VB.ProjectTemplates.Desktop",
"Microsoft.NetCore.VB.ProjectTemplates.Test",
"Microsoft.WindowsDesktop.SharedFramework.6.0.6.0.5",
"Microsoft.NetCore.Templates.6.0.6.0.400-preview.22301.10",
"Microsoft.VisualStudio.Component.Common.Azure.Tools",
"Microsoft.VisualStudio.TextTemplating.Integration.Resources",
"Microsoft.Component.MSBuild",
"Microsoft.NuGet.Build.Tasks.Setup",
"Microsoft.VisualStudio.VC.Templates.UnitTest.Resources",
"Microsoft.VisualStudio.Component.Roslyn.Compiler",
"Microsoft.CodeAnalysis.Compilers",
"Microsoft.VisualStudio.Component.JavaScript.Diagnostics",
"Microsoft.VisualStudio.PackageGroup.JavaScript.EdgeAdapterHost",
"Microsoft.VisualStudio.JavaScript.EdgeAdapterHost",
"Microsoft.VisualStudio.JavaScript.EdgeAdapter",
"Win11SDK_10.0.22621",
"Microsoft.VisualCpp.ATL.X64",
"Microsoft.VisualStudio.VirtualTree",
"Microsoft.VC.14.33.17.3.Props.ATLMFC",
"Microsoft.VisualStudio.Component.Windows11SDK.22621",
"Microsoft.Net.Component.4.8.1.SDK",
"Microsoft.VisualStudio.Graphics.Msi",
"Microsoft.VisualStudio.TestTools.TestPlatform.V1.CPP",
"Microsoft.VisualStudio.VC.Templates.Desktop",
"Microsoft.VisualStudio.Graphics.Viewers.Resources",
"Microsoft.VisualStudio.Initializer",
"Microsoft.VisualStudio.Graphics.Analyzer",
"Microsoft.VC.14.33.17.3.Premium.Tools.HostX86.TargetX86.base",
"Microsoft.VisualStudio.PackageGroup.DotNetCoreDebugging",
"Microsoft.VisualStudio.MinShell.Targeted",
"Microsoft.DiagnosticsHub.Runtime.ExternalDependencies.Targeted",
"Microsoft.VisualStudio.Templates.CS.ManagedWeb.Shared",
"Microsoft.NetCore.VB.ProjectTemplates",
"Microsoft.DiagnosticsHub.Instrumentation",
"Microsoft.ComponentGroup.ClickOnce.Publish",
"Microsoft.NetCore.CSharp.ProjectTemplates.Desktop",
"Microsoft.VC.14.33.17.3.Prem.HostX86.TargetX86.Res.base",
"Microsoft.Net.4.8.TargetingPack",
"Microsoft.Net.4.8.TargetingPack.Resources",
"Microsoft.VisualStudio.VC.Ide.TestAdapterForGoogleTest",
"Microsoft.VisualStudio.Component.VC.ATL",
"Microsoft.VisualCpp.ATL.X86",
"Microsoft.VC.14.33.17.3.CRT.x86.Store.base",
"Microsoft.VisualCpp.CRT.x86.OneCore.Desktop",
"Microsoft.VisualCpp.Premium.Tools.HostX64.TargetX86",
"Microsoft.VC.14.33.17.3.Premium.Tools.HostX64.TargetX86.base",
"Microsoft.VisualCpp.Tools.Core.x86",
"Microsoft.VC.14.33.17.3.Prem.HostX64.TargetX86.Res.base",
"Microsoft.VisualStudio.Workload.NativeDesktop",
"Microsoft.VC.14.33.17.3.Tools.Core.Props",
"Microsoft.VisualCpp.DIA.SDK",
"Microsoft.VisualCpp.Premium.Tools.HostX64.TargetX64",
"Microsoft.VisualCpp.Servicing.DIASDK",
"Microsoft.VisualCpp.CRT.x86.Desktop",
"Microsoft.VC.14.33.17.3.CRT.Source.base",
"Microsoft.VisualCpp.CRT.Redist.X86",
"Microsoft.VC.14.32.17.2.CRT.Redist.X86.base",
"Microsoft.VisualCpp.CRT.Redist.X64",
"Microsoft.VC.14.32.17.2.CRT.Redist.X64.base",
"Component.IncredibuildMenu",
"IncredibuildMenu2022",
"Microsoft.VisualCpp.CRT.x64.Store",
"Microsoft.VC.14.33.17.3.CRT.Headers.base",
"Incredibuild",
"Microsoft.VisualStudio.Templates.VB.ManagedWeb.Resources",
"Microsoft.ClickOnce.SignTool.Msi",
"Microsoft.Windows.UniversalCRT.Redistributable.Msi",
"Microsoft.VisualCpp.Redist.14",
"Microsoft.SQL.ClickOnceBootstrapper.Msi",
"Microsoft.VC.14.33.17.3.Premium.Tools.HostX64.TargetX64.base",
"Microsoft.VisualStudio.Component.AppInsights.Tools",
"Microsoft.VisualStudio.InstrumentationEngine",
"Microsoft.VisualStudio.ApplicationInsights.Interfaces",
"Microsoft.DiagnosticsHub.Collection.Service",
"Microsoft.VisualStudio.ApplicationInsights",
"Microsoft.VisualStudio.Web.Mvc",
"Microsoft.VisualStudio.Web.Mvc.Common",
"Microsoft.FSharp.Compiler",
"Microsoft.AspNetCore.SharedFramework.6.0.6.0.5-servicing.22218.2",
"Microsoft.NetCore.TargetingPack.6.0.6.0.5",
"Microsoft.VisualCpp.RuntimeDebug.14",
"Microsoft.VisualCpp.RuntimeDebug.14",
"Microsoft.VC.14.32.17.2.CRT.Redist.x86.OneCore.Desktop.base",
"Microsoft.VC.14.33.17.3.Servicing.Compilers",
"Microsoft.VC.14.33.17.3.Tools.HostX86.TargetX64.base",
"Microsoft.VC.14.33.17.3.Props.x64",
"Microsoft.VisualStudio.Component.VC.TestAdapterForGoogleTest",
"Microsoft.VisualCpp.CRT.x64.Desktop",
"Microsoft.VisualCpp.CRT.Source",
"Microsoft.VC.14.33.17.3.Servicing.ATL",
"Microsoft.VisualCpp.CRT.Redist.x64.OneCore.Desktop",
"Microsoft.VisualCpp.PGO.Headers",
"Microsoft.VC.14.32.17.2.CRT.Redist.x64.OneCore.Desktop.base",
"Microsoft.VisualCpp.CRT.x86.Store",
"Microsoft.VisualStudio.VC.ExternalBuildFramework",
"Microsoft.VisualCpp.Tools.Hostx86.Targetx64.Res",
"Microsoft.VC.14.33.17.3.ATL.X86.base",
"Microsoft.VC.14.33.17.3.Servicing",
"Component.Incredibuild",
"Microsoft.VisualStudio.VC.Templates.UnitTest",
"Microsoft.Net.4.8.1.SDK",
"Microsoft.VisualStudio.MinShell.Auto",
"Microsoft.VisualStudio.Component.VC.Redist.14.Latest",
"Microsoft.VisualStudio.Graphics.Viewers",
"Microsoft.VisualStudio.Community.VB.Targeted",
"Microsoft.VisualStudio.Component.AspNet",
"Microsoft.VC.14.33.17.3.ASAN.X64.base",
"Microsoft.VisualStudio.PackageGroup.WebToolsExtensions.Templates",
"Microsoft.VisualStudio.MefHosting",
"Microsoft.VisualStudio.Platform.Editor",
"Microsoft.VisualStudio.MefHosting.Resources",
"Microsoft.VC.14.33.17.3.Prem.HostX64.TargetX64.Res.base",
"Microsoft.VisualStudio.Templates.VB.ManagedWeb",
"Microsoft.VisualStudio.NativeImageSupport",
"Microsoft.VisualStudio.MinShell.Resources.x64",
"Microsoft.VisualStudio.Devenv.Config",
"Microsoft.VisualStudio.MinShell.Auto.Resources",
"Microsoft.VisualStudio.Templates.CS.ManagedWeb",
"Microsoft.VisualCpp.CRT.Redist.Resources",
"Microsoft.VC.14.33.17.3.Tools.HostX86.TargetX86.base",
"Microsoft.VisualStudio.Templates.CS.ManagedWeb.Resources",
"Microsoft.WebTools.ProjectTemplates",
"Microsoft.VisualStudio.ComponentGroup.NativeDesktop.Core",
"Microsoft.VisualStudio.PackageGroup.VC.Tools.x86",
"Microsoft.VisualCpp.CRT.x64.OneCore.Desktop",
"Microsoft.VisualStudio.VC.UnitTest.Desktop.Build.Core",
"Microsoft.VisualStudio.PackageGroup.TestTools.Native",
"Microsoft.VisualCpp.Tools.HostX86.TargetX86",
"Microsoft.VisualCpp.Tools.HostX86.TargetX64",
"Microsoft.VC.14.33.17.3.Tools.Hostx86.Targetx64.Res.base",
"Microsoft.VisualCpp.Redist.14.Latest",
"Microsoft.VisualCpp.Tools.HostX86.TargetX86.Res",
"Microsoft.WebTools.ItemTemplates",
"Microsoft.VisualCpp.CRT.Redist.x86.OneCore.Desktop",
"Microsoft.VisualCpp.Redist.14.Latest",
"Microsoft.VC.14.33.17.3.Props.x86",
"Microsoft.VC.14.33.17.3.CRT.x64.Desktop.base",
"Microsoft.VisualStudio.VC.CMake",
"Microsoft.VisualStudio.PackageGroup.WebStackRuntime",
"Microsoft.VC.14.33.17.3.CRT.x86.OneCore.Desktop.base",
"Microsoft.VisualStudio.Extensibility.Container",
"Microsoft.VisualStudio.PackageGroup.Progression",
"Microsoft.VisualCpp.Tools.Common.Utils.Resources",
"Microsoft.VisualStudio.Graphics.Analyzer.Targeted",
"Microsoft.VisualStudio.PackageGroup.AspNet",
"Microsoft.VisualCpp.Tools.Common.Utils",
"Microsoft.VisualStudio.Graphics.EnableTools",
"Microsoft.VisualStudio.AspNetPackages.Msi",
"Microsoft.VisualStudio.Component.VC.TestAdapterForBoostTest",
"Microsoft.VisualStudio.VC.Ide.TestAdapterForBoostTest",
"Microsoft.VisualStudio.PerformanceProvider",
"Microsoft.VisualStudio.Platform.Terminal",
"Microsoft.PythonTools.Core.Vsix",
"Microsoft.VisualStudio.Component.AspNet45",
"Microsoft.VisualCpp.ATL.Source",
"Microsoft.VisualStudio.AspNet45.Feature",
"Microsoft.VC.14.33.17.3.ATL.Source.base",
"Microsoft.VisualStudio.Component.IntelliCode",
"Microsoft.VisualStudio.VC.CMake.Project",
"Microsoft.VisualStudio.IntelliCode.FindReplaceByExample",
"Microsoft.VisualStudio.Graphics.Analyzer.Resources",
"Microsoft.VisualStudio.IntelliCode.CSharp",
"Microsoft.VC.14.33.17.3.Props",
"Microsoft.VisualCpp.ATL.Headers",
"Microsoft.VC.14.33.17.3.CRT.x86.Desktop.base",
"Microsoft.VisualStudio.Component.VC.CMake.Project",
"Microsoft.VisualStudio.VC.Ide.Core.VCProjectEngine.Resources",
"Microsoft.VisualStudio.VC.Llvm.Base",
"Microsoft.VC.14.33.17.3.Tools.HostX86.TargetX86.Res.base",
"Microsoft.VC.14.33.17.3.ASAN.Headers.base",
"Microsoft.VisualCpp.Tools.Core.Resources",
"Microsoft.Icecap.Collection.Msi",
"Microsoft.VisualStudio.ExtensionManager",
"Microsoft.PythonTools.Core.Vsix.Resources",
"Microsoft.VC.14.33.17.3.ASAN.X86.base",
"Microsoft.VisualCpp.ASAN.X86",
"Microsoft.Icecap.Collection.Msi.Targeted",
"Microsoft.Icecap.Collection.Msi.Resources",
"Microsoft.Icecap.Collection.Msi.Resources.Targeted",
"Microsoft.VisualStudio.VC.Ide.ATL.Resources",
"Microsoft.VC.14.33.17.3.ATL.Headers.base",
"Microsoft.VisualStudio.Component.VC.ASAN",
"Microsoft.VisualStudio.VC.Ide.LanguageService.Resources",
"Microsoft.VisualStudio.Templates.CS.EdgeDriverTest",
"Microsoft.VisualStudio.VC.Ide.Base.Resources",
"Microsoft.DiagnosticsHub.IceCap.Instrumentation",
"Microsoft.DiagnosticsHub.CpuSampling",
"Microsoft.DiagnosticsHub.CpuSampling.Targeted",
"Microsoft.PackageGroup.DiagnosticsHub.Platform",
"Microsoft.DiagnosticsHub.Runtime.ExternalDependencies",
"Microsoft.VC.14.33.17.3.CRT.x64.OneCore.Desktop.base",
"Microsoft.DiagnosticsHub.Runtime",
"Microsoft.VisualCpp.CRT.Headers",
"Microsoft.VisualStudio.ComponentGroup.WebToolsExtensions.CMake",
"Microsoft.VisualCpp.PGO.X86",
"Microsoft.VisualStudio.PackageGroup.Community",
"Microsoft.WebViewRuntime.Bootstrapper",
"Microsoft.VisualStudio.TextTemplating.Integration",
"Microsoft.VisualStudio.TextTemplating.Core",
"Microsoft.DiagnosticsHub.Runtime.Targeted",
"Microsoft.DiagnosticsHub.Collection.ExternalDependencies.x64",
"Microsoft.DiagnosticsHub.Collection",
"Microsoft.Net.Component.4.8.TargetingPack",
"Microsoft.NetCore.CSharp.ProjectTemplates",
"Microsoft.NetStandard.FSharp.ProjectTemplates",
"Microsoft.VisualCpp.CRT.ClickOnce.Msi",
"Microsoft.VisualStudio.PackageGroup.ClickOnce.MSBuild",
"Microsoft.FSharp.VSIX.Full.Core",
"Microsoft.NetCore.Component.Runtime.6.0",
"Microsoft.WindowsDesktop.SharedFramework.6.0.6.0.5",
"Microsoft.NetCore.TargetingPack.6.0.6.0.5",
"Microsoft.Net.Core.BootstrapperPackages",
"Microsoft.Net.4.7.2.TargetingPack",
"Microsoft.Net.4.7.2.TargetingPack.Resources",
"Microsoft.VC.14.33.17.3.PGO.X86.base",
"Microsoft.VisualCpp.PGO.X64",
"Microsoft.VC.14.33.17.3.PGO.X64.base",
"Microsoft.NetCore.CSharp.ProjectTemplates.Test",
"Microsoft.VC.14.33.17.3.PGO.Headers.base",
"Microsoft.VisualStudio.TestTools.TestPlatform.V1.CLI",
"Microsoft.VisualStudio.PackageGroup.TestTools.Core",
"Microsoft.VisualStudio.PackageGroup.TestTools.TestPlatform.V2.CLI",
"Microsoft.VisualStudio.TestTools.TestPlatform.V2.CLI",
"Microsoft.VisualStudio.TestTools.Pex.Common",
"Microsoft.VisualStudio.PackageGroup.TestTools.TestPlatform.V1.CLI",
"Microsoft.VisualStudio.PackageGroup.TestTools.TestPlatform.Legacy",
"Microsoft.VisualStudio.PackageGroup.MinShell.Interop",
"Microsoft.VisualStudio.TestTools.TP.Legacy.Tips.Msi",
"Microsoft.VisualStudio.TestTools.TP.Legacy.Tips.Common",
"Microsoft.VisualStudio.TestTools.TestPlatform.Legacy.Tips",
"Microsoft.VisualStudio.TestTools.TestPlatform.Legacy.Tips.Resources",
"Microsoft.VisualStudio.TestTools.TestPlatform.Legacy.TestSettings",
"Microsoft.VisualStudio.TestTools.TestPlatform.Legacy.Professional",
"Microsoft.VisualStudio.TestTools.TestPlatform.Legacy.Common",
"Microsoft.VisualStudio.TestTools.TP.Legacy.Common.Res",
"Microsoft.VisualStudio.TestTools.TestPlatform.Legacy.Core",
"Microsoft.VisualStudio.TestTools.TestPlatform.Legacy.Core.Resources",
"Microsoft.VisualStudio.TestTools.TestPlatform.Legacy.Agent",
"Microsoft.VisualStudio.PackageGroup.TestTools.TestPlatform.IDE",
"Microsoft.VisualStudio.TestTools.TestWIExtension",
"Microsoft.VisualStudio.TestTools.TestPlatform.IDE",
"Microsoft.CredentialProvider",
"Microsoft.VisualStudio.TextTemplating.MSBuild",
"Microsoft.VisualStudio.InteractiveWindow",
"Microsoft.VisualStudio.Component.Roslyn.LanguageServices",
"Microsoft.DiaSymReader.Native",
"Microsoft.VisualStudio.Branding.Community",
"Microsoft.VisualCpp.Redist.14",
"Microsoft.VisualCpp.Servicing.Redist",
"Microsoft.VisualStudio.PackageGroup.StaticAnalysis",
"Microsoft.VisualStudio.StaticAnalysis.IDE",
"Microsoft.VisualStudio.StaticAnalysis.IDE.Resources",
"Microsoft.VisualStudio.StaticAnalysis.auxil",
"Microsoft.VisualStudio.StaticAnalysis.FxCop",
"Microsoft.VisualStudio.StaticAnalysis.FxCop.Resources",
"Microsoft.VisualStudio.StaticAnalysis.auxil.Resources",
"Microsoft.VisualStudio.JavaScript.ChromeAdapterHost",
"Roslyn.VisualStudio.Setup.ServiceHub",
"Microsoft.VisualStudio.PackageGroup.JavaScript.ChromeAdapterHost",
"Microsoft.VisualStudio.JavaScript.ChromeAdapter",
"Microsoft.VisualStudio.Web.PerformanceTools",
"Microsoft.VisualStudio.Web.PerformanceTools.Resources",
"Microsoft.VisualStudio.Component.JavaScript.TypeScript",
"Microsoft.VisualStudio.JavaScript.ProjectSystem",
"Microsoft.VisualStudio.ComponentGroup.WebToolsExtensions",
"Microsoft.VisualStudio.ProTools",
"Microsoft.VisualStudio.PackageGroup.Debugger.Script",
"Microsoft.VisualStudio.Debugger.Script.Msi",
"sqlsysclrtypes",
"SQLCommon.amd64",
"SQLCommon",
"Microsoft.VisualStudio.ProTools.Resources",
"Microsoft.VisualStudio.Web.Scaffolding",
"Microsoft.VisualStudio.WebToolsExtensions",
"Microsoft.VisualStudio.WebToolsExtensions.MSBuild",
"Microsoft.VisualStudio.ConnectedServices.Core",
"Microsoft.VisualStudio.WebTools.WSP.FSA",
"Microsoft.VisualStudio.WebTools",
"Microsoft.VisualStudio.WebTools.Resources",
"Microsoft.VisualStudio.WebTools.WSP.FSA.Resources",
"Microsoft.VisualStudio.Component.TypeScript.TSServer",
"Microsoft.VisualStudio.Package.TypeScript.TSServer",
"TypeScript.Build",
"Microsoft.VisualStudio.Community.VB.x64",
"Microsoft.Net.Component.4.7.2.TargetingPack",
"Microsoft.VisualStudio.Workload.CoreEditor",
"Microsoft.VisualStudio.Component.CoreEditor",
"Microsoft.Net.PackageGroup.4.8.Redist",
"Microsoft.VisualStudio.PackageGroup.VC.CoreIDE.Reduced",
"Microsoft.VisualStudio.VC.Ide.MDD",
"Microsoft.VisualStudio.PackageGroup.Core",
"Microsoft.VisualStudio.TestTools.TeamFoundationClient",
"Microsoft.PackageGroup.ClientDiagnostics",
"Microsoft.VisualStudio.AppResponsiveness",
"Microsoft.VisualStudio.AppResponsiveness.Targeted",
"Microsoft.VisualStudio.GraphModel",
"Microsoft.VisualStudio.GraphProvider",
"Microsoft.VisualStudio.ClientDiagnostics",
"Microsoft.VisualStudio.ClientDiagnostics.Targeted",
"Microsoft.VisualStudio.ClientDiagnostics.Resources",
"Microsoft.VisualStudio.PackageGroup.CommunityCore",
"Microsoft.VisualStudio.ProjectSystem.Full",
"Microsoft.VisualStudio.LiveShareApi",
"Microsoft.VisualStudio.ProjectSystem.Query",
"Microsoft.VisualStudio.ProjectSystem",
"Microsoft.VisualStudio.Community.x86",
"Microsoft.VisualStudio.Community.x64",
"Microsoft.VisualStudio.Community.Msi.Resources",
"Microsoft.VisualStudio.Community.Msi",
"Microsoft.VisualStudio.Community.Shared.Msi",
"Microsoft.VisualStudio.Devenv.Msi",
"Microsoft.VisualStudio.Devenv.Shared.Msi",
"Microsoft.VisualStudio.MinShell.Interop.Msi",
"Microsoft.VisualStudio.MinShell.Interop.Shared.Msi",
"Microsoft.VisualStudio.PackageGroup.CoreEditor",
"Microsoft.WebView2",
"Microsoft.VisualStudio.Community.ProductArch.NeutralExtra",
"Microsoft.DiaSymReader.PortablePdb",
"Microsoft.IntelliTrace.CollectorCab",
"Microsoft.VisualStudio.Community.VB.Resources.Targeted",
"Microsoft.VisualStudio.Community.VB.Resources.Neutral",
"Microsoft.VisualStudio.Community.CSharp.Resources.Targeted",
"Microsoft.VisualStudio.Community.CSharp.Resources.Neutral",
"Microsoft.VisualStudio.Community.ProductArch.Resources.NeutralExtra",
"Microsoft.VisualStudio.Net.Eula.Resources",
"Microsoft.VisualStudio.Community.ProductArch.Resources.Neutral",
"Microsoft.VisualStudio.WebSiteProject.DTE",
"Microsoft.VisualStudio.Diagnostics.AspNetHelper",
"Microsoft.VisualStudio.Diagnostics.AspNetHelper.Standard",
"Microsoft.MSHtml",
"Microsoft.VisualStudio.Devenv.Resources",
"Microsoft.VisualStudio.CoreEditor",
"Microsoft.VisualStudio.Navigation.RichCodeNav",
"Microsoft.VisualStudio.Platform.NavigateTo",
"Microsoft.VisualStudio.Connected",
"Microsoft.VisualStudio.Connected.Auto",
"Microsoft.VisualStudio.Connected.Auto.Resources",
"Microsoft.VisualStudio.AzureSDK",
"Microsoft.VisualStudio.Connected.Resources",
"Microsoft.VisualStudio.VC.Ide.x64",
"Microsoft.VisualStudio.PackageGroup.VC.CoreIDE.Express",
"Microsoft.VisualStudio.VC.vcvars",
"Microsoft.VS.VC.vcvars.x86.Shortcuts",
"Microsoft.VS.VC.vcvars.x64.Shortcuts",
"Microsoft.VisualStudio.Debugger.Script",
"Microsoft.VisualStudio.Debugger.Script.Resources",
"Microsoft.VisualStudio.Debugger.Script.Remote",
"Microsoft.VisualStudio.Debugger.Script.Remote",
"Microsoft.VisualStudio.Debugger.Script.Remote.Resources",
"Microsoft.VisualStudio.Debugger.Script.Remote.Resources",
"Microsoft.VisualStudio.PackageGroup.Debugger.Core",
"Microsoft.VisualStudio.Debugger.AzureAttach",
"Microsoft.VisualStudio.Web.Azure.Common",
"Microsoft.WebTools.Shared",
"Microsoft.WebTools.DotNet.Core.ItemTemplates",
"Microsoft.VisualStudio.PackageGroup.Debugger.TimeTravel.Replay",
"Microsoft.VisualStudio.Debugger.CollectionAgents",
"Microsoft.VisualStudio.Debugger.Managed",
"Microsoft.CodeAnalysis.VisualStudio.Setup",
"Microsoft.VisualStudio.Debugger.Concord.Managed",
"Microsoft.VisualStudio.Debugger.Concord.Managed.Resources",
"Microsoft.VisualStudio.Debugger.Managed.Resources",
"Microsoft.VisualStudio.Debugger.TargetComposition",
"Microsoft.VisualStudio.Debugger.TargetComposition.Remote",
"Microsoft.VisualStudio.Debugger.TargetComposition.Remote",
"Microsoft.VisualStudio.Debugger.Remote",
"Microsoft.VisualStudio.Debugger.Concord.Remote",
"Microsoft.VisualStudio.Debugger.Concord.Remote.Resources",
"Microsoft.VisualStudio.Debugger.Remote",
"Microsoft.VisualStudio.Debugger.Concord.Remote.Resources",
"Microsoft.VisualStudio.Debugger.Remote.Resources",
"Microsoft.VisualStudio.Debugger.Remote.Resources",
"Microsoft.VisualStudio.Debugger",
"Microsoft.VisualStudio.ScriptedHost.Targeted",
"Microsoft.VisualStudio.Debugger.Package.DiagHub.Client",
"Microsoft.VisualStudio.Debugger.Concord",
"Microsoft.VisualStudio.Debugger.Concord.Resources",
"Microsoft.VisualStudio.Debugger.Resources",
"Microsoft.VisualStudio.PerfLib",
"Microsoft.VisualStudio.Debugger.Remote.DiagnosticsHub.Client",
"Microsoft.VisualStudio.PackageGroup.DebuggerClient.Core",
"Microsoft.VisualStudio.Debugger.BrokeredServices",
"Microsoft.VisualStudio.DebuggerClient.Remote",
"Microsoft.VisualStudio.Community.ProductArch.Resources.Targeted",
"Microsoft.VisualStudio.DebuggerClient.Concord.Remote",
"Microsoft.VisualStudio.DebuggerClient.Concord.Remote.Resources",
"Microsoft.VisualStudio.DebuggerClient.Remote.Resources",
"Microsoft.VisualStudio.Debugger.Parallel",
"Microsoft.VisualStudio.Debugger.Parallel.Resources",
"Microsoft.VisualStudio.DebuggerClient.Managed",
"Microsoft.DiaSymReader",
"Microsoft.CodeAnalysis.ExpressionEvaluator",
"Microsoft.VisualStudio.DebuggerClient.Concord.Managed",
"Microsoft.VisualStudio.DebuggerClient.Concord.Managed.Resources",
"Microsoft.VisualStudio.DebuggerClient",
"Microsoft.VisualStudio.Editors",
"Microsoft.VisualStudio.DebuggerClient.Concord",
"Microsoft.VisualStudio.DebuggerClient.Concord.Resources",
"Microsoft.VisualStudio.DebuggerClient.Resources",
"Microsoft.VisualStudio.VC.MSBuild.v170.X64.v143",
"Microsoft.VisualStudio.VC.MSBuild.v170.X64",
"Microsoft.VisualStudio.VC.MSBuild.v170.ARM.v143",
"Microsoft.VisualStudio.VC.MSBuild.v170.ARM",
"Microsoft.VisualStudio.VC.MSBuild.v170.x86.v143",
"Microsoft.VisualStudio.VC.MSBuild.v170.X86",
"Microsoft.VisualStudio.VC.MSBuild.v170.Base",
"Microsoft.VisualStudio.VC.MSBuild.v170.Base.Resources",
"Microsoft.VisualStudio.VC.Ide.WinXPlus",
"Microsoft.VisualStudio.VC.Ide.Dskx",
"Microsoft.VisualStudio.VC.Ide.Dskx.Resources",
"Microsoft.VisualStudio.VC.Ide.Debugger",
"Microsoft.VisualStudio.VC.Ide.Debugger.Concord",
"Microsoft.VisualStudio.VC.Ide.Debugger.Concord.Resources",
"Microsoft.VisualStudio.VC.Ide.Debugger.Resources",
"Microsoft.VisualStudio.VC.Ide.Common",
"Microsoft.VisualStudio.VC.MSVCDis",
"Microsoft.VisualStudio.VC.Ide.Common.Resources",
"Microsoft.VisualStudio.VC.Ide.Base",
"Microsoft.VisualStudio.VC.Ide.LanguageService",
"Microsoft.VisualStudio.Cache.Service",
"Microsoft.VisualStudio.VC.Ide.SecurityIssueAnalysis.Scripts",
"Microsoft.VisualStudio.VC.Ide.SecurityIssueAnalysis.PythonDistro",
"Microsoft.VisualStudio.VC.Ide.SecurityIssueAnalysis.3rdPartyLibs.10",
"Microsoft.VC.14.33.17.3.Servicing.CrtHeaders",
"Microsoft.VC.14.33.17.3.CRT.x64.Store.base",
"TypeScript.LanguageService",
"TypeScript.Tools",
"Microsoft.VisualStudio.Community.VB.x86",
"Microsoft.VisualStudio.Community.VB.Neutral",
"Microsoft.VisualStudio.Platform.CallHierarchy",
"Microsoft.VisualStudio.Community.ProductArch.Neutral",
"Microsoft.VisualStudio.MinShell",
"Microsoft.Net.6.WindowsDesktop.Runtime",
"Microsoft.Net.6.Runtime",
"Microsoft.VisualStudio.PackageGroup.Setup.Common",
"Microsoft.VisualStudio.Setup.WMIProvider",
"Microsoft.VisualStudio.Setup.Configuration.Interop",
"Microsoft.VisualCpp.Tools.Common.UtilsPrereq",
"Microsoft.VisualStudio.PackageGroup.VsDevCmd",
"Microsoft.VisualStudio.VsDevCmd.Ext.NetFxSdk",
"Microsoft.VisualStudio.VsDevCmd.Core.WinSdk",
"Microsoft.VisualStudio.VsDevCmd.Core.DotNet",
"Microsoft.VisualStudio.VC.DevCmd",
"Microsoft.VisualStudio.VC.DevCmd.Resources",
"Microsoft.Build.Dependencies",
"Microsoft.Build.FileTracker.Msi",
"Microsoft.DataAI.NuGetRecommender",
"Microsoft.Build",
"Microsoft.VisualStudio.PackageGroup.NuGet",
"Microsoft.VisualStudio.NuGet.Core",
"Microsoft.Build.UnGAC",
"Microsoft.VisualStudio.TextMateGrammars",
"Microsoft.VisualStudio.Platform.CrossRepositorySearch",
"Microsoft.VisualStudio.PackageGroup.TeamExplorer.Common",
"Microsoft.VisualStudio.Community.CSharp.Targeted",
"Microsoft.VisualStudio.Community.CSharp.Neutral",
"Microsoft.VisualStudio.Community.ProductArch.TargetedExtra",
"Microsoft.VisualStudio.Community.ProductArch.Targeted",
"Microsoft.ServiceHub.Node",
"Microsoft.VisualStudio.TeamExplorer",
"Microsoft.VisualStudio.PackageGroup.ServiceHub",
"Microsoft.ServiceHub.Managed",
"Microsoft.ServiceHub.dotnet.x64",
"Microsoft.VisualStudio.ProjectServices",
"Microsoft.VisualStudio.OpenFolder.VSIX",
"Microsoft.VisualStudio.FileHandler.Msi",
"Microsoft.VisualStudio.FileHandler.Msi",
"Microsoft.VisualStudio.PackageGroup.MinShell",
"Microsoft.VisualStudio.MinShell.Msi",
"Microsoft.VisualStudio.LanguageServer",
"Microsoft.VisualStudio.MinShell.Shared.Msi",
"Microsoft.VisualStudio.MinShell.Msi.Resources",
"Microsoft.VisualStudio.MinShell.Interop",
"CoreEditorFonts",
"Microsoft.VisualStudio.Log.Resources",
"Microsoft.VisualStudio.Log",
"Microsoft.VisualStudio.Log.Targeted",
"Microsoft.VisualStudio.Finalizer",
"Microsoft.VisualStudio.Devenv",
"Microsoft.VisualStudio.Debugger.Concord.Remote",
"Microsoft.VisualStudio.Debugger.VSCodeDebuggerHost",
"Microsoft.VisualStudio.VC.Ide.SecurityIssueAnalysis.3rdPartyLibs.9",
"Microsoft.VisualStudio.VC.Ide.SecurityIssueAnalysis.3rdPartyLibs.8",
"Microsoft.VisualStudio.VC.Ide.SecurityIssueAnalysis.3rdPartyLibs.7",
"Microsoft.VisualStudio.VC.Ide.SecurityIssueAnalysis.3rdPartyLibs.6",
"Microsoft.VisualStudio.VC.Ide.VCPkgDatabase",
"Microsoft.VisualStudio.VC.Ide.SecurityIssueAnalysis.3rdPartyLibs.5",
"Microsoft.VisualStudio.Setup.Configuration",
"Microsoft.VisualStudio.VC.Ide.SecurityIssueAnalysis.3rdPartyLibs.4",
"Microsoft.VisualStudio.VC.Ide.SecurityIssueAnalysis.3rdPartyLibs.2",
"Microsoft.VisualStudio.VC.Ide.SecurityIssueAnalysis.3rdPartyLibs.1",
"Microsoft.VisualStudio.VC.Ide.ResourceEditor",
"Microsoft.VisualStudio.VC.Ide.ResourceEditor.Resources",
"Microsoft.VisualStudio.VC.Ide.ProjectSystem",
"Microsoft.VisualStudio.VC.Ide.Progression.Enterprise",
"Microsoft.VisualStudio.VC.Ide.Core",
"Microsoft.VisualStudio.VisualC.Utilities",
"Microsoft.VisualStudio.VisualC.Utilities.Resources",
"Microsoft.VisualStudio.VC.Ide.ProjectSystem.Resources",
"Microsoft.VisualStudio.VC.Ide.Core.VCProjectEngine"
]
}
]
Just approved it. Thank you! |
|
@mavaddat I'm not a regular reviewer for node-gyp nor do regularly work on Windows. I think the problem is that we want a reviewer from @nodejs/platform-windows but those who are interested/supported to work on windows are quite limited in the project right now. |
|
@mhdawson I understand that you want a reviewer from @nodejs/platform-windows, but how long shall we wait for a review? What is appropriate here? It has been 8 months so far. It is quite frustrating for me to spend my time and contribute to a bug fix here and nothing happens. |
|
@nsait-linaro any chance you could take a look and confirm it looks good to you? |
Is there online windows 11 in our CI I can verify this ? cc @joaocgreis |
As @hubbergit mentioned, you only need the Windows 11 SDK, not (necessarily) the Windows 11 Operating System. The Windows 11 SDK can run on any Windows operating system including:
|
|
The node-gyp project already tests on Windows as well. |
The CI runs on windows-server, it's not the same.
I am aware of that. It's still important to get it tested on windows 11. But looks from user, it's tested good from feedback. @rvagg thoughts ? |
This comment was marked as off-topic.
This comment was marked as off-topic.
|
@gengjiawen I guess this is fine to move forward with - it at least doesn't look like it breaks existing functionality so it's just a question of whether it adds the new desired functionality. The only thing that's sus to me is |
|
The NT version of Win11 is 10.0.x, just like Win10, see versions on Wikipedia It's usual for Windows, Win7 was 6.1.* for example. It is certainly not any more broken than it was before. The one true way for finding Windows SDK is using the envvars vs dev cmd sets and forcing everyone to compile in vs dev cmd. For everything else, we're left with these best effort finder scripts. |
gengjiawen
changed the title
|
@rvagg Thx. Also I understand the frustration it's get merged for a long time. But none of us got paid for this work. |
Looks like I am a bit late. Anyway, Looks good to me. |
|
New release should be in #2702. Please follow-up there. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
fix: Fixes #2527
Latest Windows 11 SDK was not supported by implementation due to a change in the naming convention made by Microsoft. The implementation has been amended to account for this change.