Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: GitHub Actions Test on node: [12.x, 14.x, 16.x] #2439

Merged
merged 4 commits into from Jun 28, 2021
Merged

ci: GitHub Actions Test on node: [12.x, 14.x, 16.x] #2439

merged 4 commits into from Jun 28, 2021

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Jun 20, 2021 •
edited

Tracks with https://nodejs.org/en/about/releases

Also removes duplicate push and pull_requests tests.

Checklist
  • npm install && npm test passes
  • tests are included
  • documentation is changed or added
  • commit message follows commit guidelines
Description of change

@cclauss cclauss requested a review from codebytere June 20, 2021 13:54
@cclauss
Remove duplicate testing
02161e0 
```yaml
on:
  push:
    branches: [ main ]
  pull_request:
    branches: [ main ]
```
@cclauss
Remove duplicate tests
304e9d5
@cclauss
Update tests.yml
3dc08f1 
on: [push, pull_request]
@gengjiawen gengjiawen changed the title GitHub Actions: Test on node: [12.x, 14.x, 16.x] ci: GitHub Actions Test on node: [12.x, 14.x, 16.x] Jun 28, 2021
@gengjiawen gengjiawen merged commit b7bccdb into master Jun 28, 2021
@gengjiawen gengjiawen deleted the node-12,14,16 branch June 28, 2021 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gengjiawen gengjiawen gengjiawen approved these changes

@codebytere codebytere Awaiting requested review from codebytere

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cclauss @gengjiawen