Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: change default gyp update message #2420

Merged
merged 1 commit into from May 29, 2021
Merged

fix: change default gyp update message #2420

merged 1 commit into from May 29, 2021

Conversation

gengjiawen
Copy link
Member

Checklist
  • npm install && npm test passes
  • tests are included
  • documentation is changed or added
  • commit message follows commit guidelines
Description of change

@gengjiawen gengjiawen requested a review from rvagg May 29, 2021 02:25
@gengjiawen gengjiawen merged commit cfd12ff into nodejs:master May 29, 2021
@gengjiawen gengjiawen deleted the gyp-auto branch May 29, 2021 12:48
@rvagg
Copy link
Member

rvagg commented May 31, 2021

not sure about this tbh, the feat vs chore will depend on what emerges out of gyp, in the last case it was a feat. Maybe this needs to depend on the semver bump in gyp? just inherit straight from that and do feat/chore/feat! based on that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

@rvagg rvagg Awaiting requested review from rvagg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gengjiawen @rvagg @cclauss