New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
git node vote
fails with ERR_INVALID_ARG_TYPE
#753
Comments
richardlau
changed the title
git node vote fails with ERR_INVALID_ARG_TYPE
Nov 17, 2023
git node vote
fails with ERR_INVALID_ARG_TYPE
FWIW I was able to vote successfully using the "on the web" link on the vote PR. |
Still happening with $ git node vote https://github.com/nodejs/TSC/pull/1540
Cloning remote repository...
Cloning into '.'...
remote: Enumerating objects: 419, done.
remote: Counting objects: 100% (419/419), done.
remote: Compressing objects: 100% (391/391), done.
remote: Total 419 (delta 31), reused 162 (delta 26), pack-reused 0
Receiving objects: 100% (419/419), 2.37 MiB | 40.52 MiB/s, done.
Resolving deltas: 100% (31/31), done.
Ballot is ready for edit.
TypeError [ERR_INVALID_ARG_TYPE]: The "file" argument must be of type string. Received null
at normalizeSpawnArguments (node:child_process:548:3)
at spawn (node:child_process:754:13)
at file:///home/rlau/.nvm/versions/node/v20.12.2/lib/node_modules/@node-core/utils/node_modules/@node-core/caritat/dist/utils/runChildProcessAsync.js:13:19
at new Promise (<anonymous>)
at default (file:///home/rlau/.nvm/versions/node/v20.12.2/lib/node_modules/@node-core/utils/node_modules/@node-core/caritat/dist/utils/runChildProcessAsync.js:4:81)
at voteAndCommit (file:///home/rlau/.nvm/versions/node/v20.12.2/lib/node_modules/@node-core/utils/node_modules/@node-core/caritat/dist/voteUsingGit.js:33:19)
at async voteUsingGit (file:///home/rlau/.nvm/versions/node/v20.12.2/lib/node_modules/@node-core/utils/node_modules/@node-core/caritat/dist/voteUsingGit.js:96:9)
at async VotingSession.start (file:///home/rlau/.nvm/versions/node/v20.12.2/lib/node_modules/@node-core/utils/lib/voting_session.js:55:5) {
code: 'ERR_INVALID_ARG_TYPE'
}
$ |
Okay, after some debugging, it looks like it can't figure out an editor. It works if I set $ EDITOR=vi git node vote https://github.com/nodejs/TSC/pull/1540
Cloning remote repository...
Cloning into '.'...
remote: Enumerating objects: 419, done.
remote: Counting objects: 100% (419/419), done.
remote: Compressing objects: 100% (391/391), done.
remote: Total 419 (delta 31), reused 162 (delta 26), pack-reused 0
Receiving objects: 100% (419/419), 2.37 MiB | 35.75 MiB/s, done.
Resolving deltas: 100% (31/31), done.
Ballot is ready for edit.
... |
Which I guess is #605. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This is with Node.js 20 and @node-core/utils@4.2.0:
The text was updated successfully, but these errors were encountered: