fix(update-v8): force-add all files after cloning V8 #549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add all V8 files with --force before updating DEPS. We have to do this because some files are checked in by V8 despite .gitignore rules.
Codecov Report
@@ Coverage Diff @@
## main #549 +/- ##
=======================================
Coverage 82.57% 82.57%
=======================================
Files 35 35
Lines 1750 1750
=======================================
Hits 1445 1445
Misses 305 305 Continue to review full report at Codecov.
|
|
See nodejs/node#38990 (comment) and discussion in https://chromium-review.googlesource.com/c/v8/v8/+/2972915 |
richardlau
approved these changes
Jun 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add all V8 files with --force before updating DEPS. We have to do this
because some files are checked in by V8 despite .gitignore rules.