Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: throw on missing info during release prep #519

Merged
merged 1 commit into from
Nov 5, 2020

Conversation

codebytere
Copy link
Member

@codebytere codebytere commented Nov 3, 2020

Fixes the following potential error:

Error: git config,--get,remote.undefined.url failed with stderr:
    at exports.runSync (/Users/mylesborins/.nvm/versions/node/v14.15.0/lib/node_modules/node-core-utils/lib/run.js:84:11)
    at new ReleasePreparation (/Users/mylesborins/.nvm/versions/node/v14.15.0/lib/node_modules/node-core-utils/lib/prepare_release.js:50:26)
    at main (/Users/mylesborins/.nvm/versions/node/v14.15.0/lib/node_modules/node-core-utils/components/git/release.js:71:18)
    at release (/Users/mylesborins/.nvm/versions/node/v14.15.0/lib/node_modules/node-core-utils/components/git/release.js:53:21)
    at Object.handler (/Users/mylesborins/.nvm/versions/node/v14.15.0/lib/node_modules/node-core-utils/components/git/release.js:38:12)
    at Object.runCommand (/Users/mylesborins/.nvm/versions/node/v14.15.0/lib/node_modules/node-core-utils/node_modules/yargs/build/lib/command.js:196:48)
    at Object.parseArgs [as _parseArgs] (/Users/mylesborins/.nvm/versions/node/v14.15.0/lib/node_modules/node-core-utils/node_modules/yargs/build/lib/yargs.js:1043:55)
    at Object.get [as argv] (/Users/mylesborins/.nvm/versions/node/v14.15.0/lib/node_modules/node-core-utils/node_modules/yargs/build/lib/yargs.js:986:25)
    at Object.<anonymous> (/Users/mylesborins/.nvm/versions/node/v14.15.0/lib/node_modules/node-core-utils/bin/git-node:22:3)
    at Module._compile (internal/modules/cjs/loader.js:1063:30)

by catching and returning when ncu-config data is not present.

cc @nodejs/node-core-utils @MylesBorins

@codebytere codebytere requested a review from a team November 3, 2020 23:17
@codecov
Copy link

codecov bot commented Nov 3, 2020

Codecov Report

Merging #519 into master will increase coverage by 0.19%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #519      +/-   ##
==========================================
+ Coverage   82.29%   82.49%   +0.19%     
==========================================
  Files          34       35       +1     
  Lines        1717     1742      +25     
==========================================
+ Hits         1413     1437      +24     
- Misses        304      305       +1     
Impacted Files Coverage Δ
lib/cli.js 88.73% <0.00%> (ø)
lib/release/utils.js 96.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6dab341...cbc8904. Read the comment docs.

@codebytere codebytere force-pushed the better-config-error branch 2 times, most recently from 6cff283 to 813e088 Compare November 3, 2020 23:21
lib/prepare_release.js Outdated Show resolved Hide resolved
lib/prepare_release.js Outdated Show resolved Hide resolved
@codebytere codebytere merged commit 223d075 into nodejs:master Nov 5, 2020
@codebytere codebytere deleted the better-config-error branch November 5, 2020 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants