Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow opt-out of Fixes/Refs metadata #474

Merged
merged 2 commits into from
Aug 15, 2020

Conversation

codebytere
Copy link
Member

@codebytere codebytere commented Aug 14, 2020

Closes #470.

Allows for a collaborator to skip Fixes: and Refs: being automatically added to generated commit metadata if --skipRefs is passed.

@codecov
Copy link

codecov bot commented Aug 14, 2020

Codecov Report

Merging #474 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #474   +/-   ##
=======================================
  Coverage   82.58%   82.59%           
=======================================
  Files          34       34           
  Lines        1665     1660    -5     
=======================================
- Hits         1375     1371    -4     
+ Misses        290      289    -1     
Impacted Files Coverage Δ
lib/metadata_gen.js 100.00% <100.00%> (ø)
lib/ci/ci_type_parser.js 81.35% <0.00%> (-0.47%) ⬇️
lib/pr_checker.js 95.49% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd566e2...1f3aa86. Read the comment docs.

@codebytere codebytere requested a review from a team August 14, 2020 16:15
Copy link
Member

@richardlau richardlau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks okay but needs tests.

@codebytere codebytere merged commit df5c572 into nodejs:master Aug 15, 2020
@codebytere codebytere deleted the fixes-refs-opt-out branch August 15, 2020 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fixes: and Refs: tags are pulled from PR description
2 participants