Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: lint during the landing process #435

Merged
merged 3 commits into from
Aug 17, 2020

Conversation

codebytere
Copy link
Member

Closes #427.

Runs make lint after the patch has been downloaded and applied, and optionally stage and amend updated files if lint fails.

@codecov
Copy link

codecov bot commented Jun 4, 2020

Codecov Report

Merging #435 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #435      +/-   ##
==========================================
- Coverage   82.58%   82.56%   -0.02%     
==========================================
  Files          34       34              
  Lines        1665     1658       -7     
==========================================
- Hits         1375     1369       -6     
+ Misses        290      289       -1     
Impacted Files Coverage Δ
lib/ci/ci_type_parser.js 81.35% <0.00%> (-0.47%) ⬇️
lib/pr_checker.js 95.49% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd566e2...9c846de. Read the comment docs.

@richardlau
Copy link
Member

Closes #427.

Runs make lint after the patch has been downloaded and applied, and optionally stage and amend updated files if lint fails.

Isn’t that going to fail on Windows?

@codebytere
Copy link
Member Author

@richardlau you might be right - my esoteric windows knowledge is admittedly weaker 😅

@targos
Copy link
Member

targos commented Jun 8, 2020

Does git node land currently work on windows ?

@codebytere
Copy link
Member Author

We could also only run make lint on linux/macOS potentially

lib/landing_session.js Outdated Show resolved Hide resolved
@codebytere codebytere marked this pull request as ready for review June 8, 2020 19:20
@BridgeAR
Copy link
Member

BridgeAR commented Jun 8, 2020

We might want add some tests for these changes.

@codebytere
Copy link
Member Author

I don't know we have tests for any of the actual patch downloading code right now - @joyeecheung what do you think?

lib/landing_session.js Outdated Show resolved Hide resolved
lib/landing_session.js Outdated Show resolved Hide resolved
lib/landing_session.js Show resolved Hide resolved
lib/landing_session.js Outdated Show resolved Hide resolved
@codebytere
Copy link
Member Author

@lundibundi i cleaned up the flow a bit - i think this is a bit better for users now

@codebytere codebytere merged commit de6d1e2 into nodejs:master Aug 17, 2020
@codebytere codebytere deleted the lint-on-land branch August 17, 2020 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run make lint during git node land
5 participants