We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I was just adding 23 to the matrix and noticed we should have added testing with VS2022 a while ago.
Seems like there are some failures - https://ci.nodejs.org/job/node-test-node-addon-api-new/nodes=win-vs2022/8773/
The text was updated successfully, but these errors were encountered:
@vmoroz will take a look.
Sorry, something went wrong.
@mhdawson , the code uses std::allocator methods construct and destroy. They were deprecated in in C++17 and removed in C++20. See https://en.cppreference.com/w/cpp/memory/allocator/construct, https://en.cppreference.com/w/cpp/memory/allocator/destroy. I will send a PR that fixes it.
std::allocator
construct
destroy
Is this fixed by #1492?
We took a look at the CI runs in the meeting today and its fixed. Many thanks @vmoroz
No branches or pull requests
I was just adding 23 to the matrix and noticed we should have added testing with VS2022 a while ago.
Seems like there are some failures - https://ci.nodejs.org/job/node-test-node-addon-api-new/nodes=win-vs2022/8773/
The text was updated successfully, but these errors were encountered: