Skip to content
This repository has been archived by the owner on Nov 6, 2022. It is now read-only.

Option to Drop support for Proxy-Connection #477

Open
Mythra opened this issue May 2, 2019 · 1 comment
Open

Option to Drop support for Proxy-Connection #477

Mythra opened this issue May 2, 2019 · 1 comment

Comments

@Mythra
Copy link

Mythra commented May 2, 2019

Currently, http-parser will always support the: Proxy-Connection header. This header is not standard, and not required for any real legitimate client:

are two examples explaining this weird header.

As a result, everything built on top of http-parser implicitly has to support this unstandard header (which can lead to some bugs if you're not expecting this unstandard case to be handled see: envoyproxy/envoy#6749 ),

It'd be great if we had a flag to turn off (or just didn't support at all) this header that isn't part of the standard.

@PiotrSikora
Copy link

cc @indutny (also, llhttp seems to handle Proxy-Connection in a similar way).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants