Skip to content
This repository has been archived by the owner on Nov 6, 2022. It is now read-only.

Group related tests into files #400

Open
maclover7 opened this issue Nov 30, 2017 · 3 comments
Open

Group related tests into files #400

maclover7 opened this issue Nov 30, 2017 · 3 comments

Comments

@maclover7
Copy link
Contributor

test.c is over four thousand lines long and is getting a little hard to parse... any objections to moving some related tests into separate files in a test/ directory?

@indutny @bnoordhuis

@bnoordhuis
Copy link
Member

Personally, I'm -0.5. Long files don't really bother me and breakups are annoying with git blame. I also don't really enjoy reviewing huge diffs.

But it Fedor thinks it's a good idea, I won't block it.

@maclover7
Copy link
Contributor Author

ping @indutny

@indutny
Copy link
Member

indutny commented Jan 9, 2018

+1 for this, sorry for delay. This may require writing a mini test framework, though.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants